GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-23082: Better error message for PurePath.relative_to() from pathlib by rotuna · Pull Request #19611 · python/cpython

Conversation

@rotuna

@rotuna rotuna commented Apr 19, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Changed the error message to be more informative and updated the docs accordingly.

https://bugs.python.org/issue23082

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Sadhana Srinivasan Sadhana Srinivasan
Better error for PurePath.relative_to() from pathlib
b979a2f 
Changed the error message to be more informative and updated the docs accordingly.
@the-knights-who-say-ni

the-knights-who-say-ni commented Apr 19, 2020

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@rotuna

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@the-knights-who-say-ni the-knights-who-say-ni added the CLA not signed label Apr 19, 2020
@bedevere-bot bedevere-bot added the awaiting review label Apr 19, 2020
@the-knights-who-say-ni the-knights-who-say-ni added CLA signed and removed CLA not signed labels Apr 20, 2020
blurb-it Bot and others added 2 commits April 20, 2020 22:08
@blurb-it
📜🤖 Added by blurb_it.
3c05582
rotuna rotuna
fixed whitespace issues
e7f0ab1
@rotuna

rotuna commented Apr 22, 2020

Copy link
Copy Markdown
Contributor Author

@zooba Could you please review this PR?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@csabella
csabella requested a review from pitrou April 23, 2020 12:04
zooba
zooba reviewed Apr 28, 2020
View reviewed changes
Comment thread Lib/pathlib.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@zooba

zooba commented Apr 28, 2020

Copy link
Copy Markdown
Member

Sorry for the delay - I had it flagged to follow-up, but life.

Pinging me on GitHub doesn't work either, btw (too many notifications; too hard to filter them). If you need my attention, please post on the bug.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@idomic

idomic commented May 24, 2020

Copy link
Copy Markdown
Contributor

The PR looks good pinging on the bug's page
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@zooba
zooba merged commit 4483253 into python:master May 25, 2020
@bedevere-bot bedevere-bot removed the awaiting review label May 25, 2020
@zooba zooba added the needs backport to 3.9 label May 25, 2020
@miss-islington

miss-islington commented May 25, 2020

Copy link
Copy Markdown
Contributor

Thanks @rotuna for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 25, 2020
@rotuna @miss-islington
bpo-23082: Better error message for PurePath.relative_to() from pathl…
0149274 
…ib (pythonGH-19611)

Co-authored-by: Sadhana Srinivasan <[email protected]>
(cherry picked from commit 4483253)

Co-authored-by: Rotuna <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.9 label May 25, 2020
@bedevere-bot

bedevere-bot commented May 25, 2020

Copy link
Copy Markdown

GH-20395 is a backport of this pull request to the 3.9 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington added a commit that referenced this pull request May 25, 2020
@miss-islington @rotuna
bpo-23082: Better error message for PurePath.relative_to() from pathl…
318a18e 
…ib (GH-19611)

Co-authored-by: Sadhana Srinivasan <[email protected]>
(cherry picked from commit 4483253)

Co-authored-by: Rotuna <[email protected]>
domragusa added a commit to domragusa/cpython that referenced this pull request May 28, 2020
@domragusa
resolve conflicts with pythonGH-19611
6d721a0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zooba zooba zooba left review comments
@pitrou pitrou Awaiting requested review from pitrou

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@rotuna @the-knights-who-say-ni @zooba @idomic @miss-islington @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.