GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-40327: Improve atomicity speed and memory efficiency of the items() loop by rhettinger · Pull Request #19628 · python/cpython

Conversation

@rhettinger

@rhettinger rhettinger commented Apr 20, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This isn't a complete solution to the OP's problem, but it does mitigate the race condition risk, and it also improves memory efficiency and speed.

https://bugs.python.org/issue40327

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@rhettinger
bpo-40327: Improve atomicity, speed, and memory efficiency of the ite…
2f60a15 
…ms() loop
@rhettinger rhettinger added performance Performance or resource usage skip news needs backport to 3.8 labels Apr 20, 2020
@rhettinger
rhettinger requested a review from serhiy-storchaka April 20, 2020 20:28
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Apr 20, 2020
@bedevere-bot bedevere-bot added the awaiting core review label Apr 20, 2020
@serhiy-storchaka serhiy-storchaka added the type-bug An unexpected behavior, bug, or error label Apr 21, 2020
@serhiy-storchaka

serhiy-storchaka commented Apr 21, 2020

Copy link
Copy Markdown
Member

👍
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@rhettinger
rhettinger merged commit 75bedbe into python:master Apr 21, 2020
@miss-islington

miss-islington commented Apr 21, 2020

Copy link
Copy Markdown
Contributor

Thanks @rhettinger for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting core review label Apr 21, 2020
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 21, 2020
@rhettinger @miss-islington
bpo-40327: Improve atomicity, speed, and memory efficiency of the ite…
0e08cb5 
…ms() loop (pythonGH-19628)

(cherry picked from commit 75bedbe)

Co-authored-by: Raymond Hettinger <[email protected]>
@bedevere-bot

bedevere-bot commented Apr 21, 2020

Copy link
Copy Markdown

GH-19640 is a backport of this pull request to the 3.8 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.8 label Apr 21, 2020
miss-islington added a commit that referenced this pull request May 22, 2020
@miss-islington @rhettinger
bpo-40327: Improve atomicity, speed, and memory efficiency of the ite…
16d0781 
…ms() loop (GH-19628)

(cherry picked from commit 75bedbe)

Co-authored-by: Raymond Hettinger <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka Awaiting requested review from serhiy-storchaka

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

performance Performance or resource usage skip news type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@rhettinger @serhiy-storchaka @miss-islington @bedevere-bot @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.