GeezerVison

@zooba Thanks for your patience, let me know if you need anything else to move forward with the integration 🙏

No news entry in Misc/NEWS.d/next/

@jcfr Seems like a release note could be added in the meantime.

Ping? Any update here? It'd be nice to have this in 3.9.

Seems this will miss 3.10 as well.

Ping. This would be really really nice to have sometime soon 👍

I thought we'd already added this? I guess if it's not there, then we should.

Definitely needs a NEWS entry, probably deserves a What's New as well. Not sure if there's any place in the documentation that would suit, but if so, we should mention it for sure.

Definitely needs a NEWS entry

I can definitely add an entry, What about the C-API section ? See https://github.com/python/cpython/tree/main/Misc/NEWS.d/next/C%20API

I added draft documentation and the NEWS entry for the macro. However, they need improvements.

@arhadthedev Thanks for your help moving this forward 🙏

I haven't tested the commands added to the docs, but if they do work as described and produce the files, then this looks fine to me.

It seems that if building Python by oneself, python's lib file will not be found in virtual environment. Hope this issue fixes as quickly as possible

No, virtual environment is only for Python libraries. You'll need to look in base_prefix to find native import libraries.

@zooba My question is like this:rosinality/stylegan2-pytorch#325 (comment)

So, is it more like to be a question about venv?

It looks like Torch is deciding those settings, and it's deciding wrong about where to find the libs files.

There's a revamp of sysconfig going on that will eventually provide a better option for them to find it, but for now, either they need to use sys.base_prefix instead of sys.prefix, or if they already are (which they might be), then there's something wrong with your venv (maybe you've chained multiple venvs together in some unsupported way?)

@zooba I can give some additional informations. For exmaple,
The source code of python is on D:\Python-3.10.12,
The binary file of Windows and also the dll file are on D:\Python-3.10.12\PCbuild\amd64

And that's maybe why dll file cannot be found?

Yeah, many tools are not going to work well when running from a CPython build directory. It's an unsupported configuration.

Try using the PC/layout tool (e.g. python PC\layout --copy <directory> --preset-default) to create an installed-shape directory. That will have the libs at the usual place relative to python.exe. (You need to re-run the command if you rebuild Python, but it does incremental copying. Also, don't run the copied Python from the CPython source directory or it'll get the wrong Lib dir.)

Any progress here? I see conflicts, so at least a rebase is in order. It'd be nice to get this into 3.13 at least…

@vstinner Interested in shepherding this C API change at all?

A rebase ought to be enough, and when someone confirms that the build commands shown in the new documentation are correct then this can be merged (as per my last message).

This would potentially be extremly helpful, any chance that this will get merged at some point?

It looks like the rebase isn't coming, so someone will need to submit a new PR.

It also looks like my last hesitation was that the commands in the docs weren't tested.

Guess we're not getting those improvements, so we'll leave them for later. Should be an easy first contribution for a sprint.

Thanks everyone for the help moving this forward 🙏