GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-40443: Remove unused imports in idlelib by vstinner · Pull Request #19801 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Apr 29, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

https://bugs.python.org/issue40443

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
bpo-40443: Remove unused imports in idlelib
32e139c
@vstinner vstinner added the skip news label Apr 29, 2020
@vstinner
vstinner requested review from csabella and terryjreedy April 29, 2020 22:51
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Apr 29, 2020
@bedevere-bot bedevere-bot added the awaiting core review label Apr 29, 2020
@vstinner

vstinner commented Apr 29, 2020

Copy link
Copy Markdown
Member Author

@terryjreedy @csabella: Would you mind to review this PR?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
terryjreedy
terryjreedy approved these changes Apr 30, 2020
View reviewed changes

@terryjreedy terryjreedy left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-use verified.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Apr 30, 2020
@terryjreedy

terryjreedy commented Apr 30, 2020

Copy link
Copy Markdown
Member

Don't understand macOS failure, and the abrupt stop. Treating as unrelated intermittent failure.

clang: warning: -framework Tk: 'linker' input unused [-Wunused-command-line-argument]
In file included from /Users/runner/runners/2.169.1/work/cpython/cpython/Modules/_tkinter.c:46:
/Applications/Xcode_11.3.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/tk.h:86:11: fatal error: 'X11/Xlib.h' file not found
#       include <X11/Xlib.h>
                ^~~~~~~~~~~~
1 error generated.

Python build finished successfully!

...
The following modules found by detect_modules() in setup.py, have been

...
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@terryjreedy
terryjreedy merged commit 6900f16 into python:master Apr 30, 2020
@bedevere-bot bedevere-bot removed the awaiting merge label Apr 30, 2020
@terryjreedy terryjreedy added needs backport to 3.7 labels Apr 30, 2020
@miss-islington

miss-islington commented Apr 30, 2020

Copy link
Copy Markdown
Contributor

Thanks @vstinner for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Apr 30, 2020

Copy link
Copy Markdown
Contributor

Thanks @vstinner for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 30, 2020
@vstinner @miss-islington
bpo-40443: Remove unused imports in idlelib (pythonGH-19801)
1faed73 
(cherry picked from commit 6900f16)

Co-authored-by: Victor Stinner <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.7 label Apr 30, 2020
@bedevere-bot

bedevere-bot commented Apr 30, 2020

Copy link
Copy Markdown

GH-19808 is a backport of this pull request to the 3.7 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 30, 2020
@vstinner @miss-islington
bpo-40443: Remove unused imports in idlelib (pythonGH-19801)
ff8ab3b 
(cherry picked from commit 6900f16)

Co-authored-by: Victor Stinner <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.8 label Apr 30, 2020
@bedevere-bot

bedevere-bot commented Apr 30, 2020

Copy link
Copy Markdown

GH-19809 is a backport of this pull request to the 3.8 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington added a commit that referenced this pull request Apr 30, 2020
@miss-islington @vstinner
bpo-40443: Remove unused imports in idlelib (GH-19801)
48ef06b 
(cherry picked from commit 6900f16)

Co-authored-by: Victor Stinner <[email protected]>
miss-islington added a commit that referenced this pull request Apr 30, 2020
@miss-islington @vstinner
bpo-40443: Remove unused imports in idlelib (GH-19801)
95e208d 
(cherry picked from commit 6900f16)

Co-authored-by: Victor Stinner <[email protected]>
@vstinner
vstinner deleted the remove_unused_imports_idle branch April 30, 2020 09:29
@vstinner

vstinner commented Apr 30, 2020

Copy link
Copy Markdown
Member Author

Terry: yeah sadly the macOS CI looks sick :-(
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner mentioned this pull request Jun 27, 2022
Remove unused imports in the stdlib (April 2020 edition) #84623
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@terryjreedy terryjreedy terryjreedy approved these changes
@csabella csabella Awaiting requested review from csabella

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@vstinner @terryjreedy @miss-islington @bedevere-bot @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.