GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-29587: Remove the exc_value NULL check in _gen_throw() by cjerdonek · Pull Request #19877 · python/cpython

Conversation

@cjerdonek

@cjerdonek cjerdonek commented May 3, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This is another follow-up to PR #19823, removing the check that exc_value isn't NULL prior to calling _PyErr_ChainExceptions(). This makes it so that exception chaining can occur in more cases.

https://bugs.python.org/issue29587

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
cjerdonek added 2 commits May 2, 2020 21:12
@cjerdonek
Remove the exc_value NULL check and add a failing test.
66aa645
@cjerdonek
Check that exc_type doesn't equal Py_None.
66ae854
@cjerdonek cjerdonek added the skip news label May 3, 2020
@cjerdonek
cjerdonek requested a review from 1st1 as a code owner May 3, 2020 04:28
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label May 3, 2020
@bedevere-bot bedevere-bot added the awaiting core review label May 3, 2020
gvanrossum
gvanrossum approved these changes May 3, 2020
View reviewed changes

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good luck!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels May 3, 2020
@cjerdonek

cjerdonek commented May 3, 2020

Copy link
Copy Markdown
Member Author

Thanks! :) I'll be posting a comment on the issue with what I found..
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@cjerdonek
cjerdonek merged commit 21893fb into python:master May 3, 2020
@bedevere-bot bedevere-bot removed the awaiting merge label May 3, 2020
@cjerdonek
cjerdonek deleted the issue-29587-allow-null-values branch May 3, 2020 07:08
This was referenced May 3, 2020
bpo-29587: Add another test for the gen.throw() exception chain fix #19859
Merged
bpo-29587: Enable exception chaining for gen.throw() with "yield from" #19858
Merged
bpo-29587: Enable implicit exception chaining with gen.throw() #19823
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes
@1st1 1st1 Awaiting requested review from 1st1

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@cjerdonek @gvanrossum @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.