GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-29587: Add another test for the gen.throw() exception chain fix by cjerdonek · Pull Request #19859 · python/cpython

Conversation

@cjerdonek

@cjerdonek cjerdonek commented May 2, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This PR just adds another failing test for bpo-29587 (following the fix in PR #19823). It tests something slightly different. I confirmed that the test fails prior to PR #19823.

https://bugs.python.org/issue29587

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label May 2, 2020
@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting core review labels May 2, 2020
@cjerdonek cjerdonek added the skip news label May 2, 2020
@cjerdonek

cjerdonek commented May 2, 2020

Copy link
Copy Markdown
Member Author

I've skipped the NEWS entry since this adds to an issue that already has a NEWS entry.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@cjerdonek cjerdonek changed the title bpo-29587: Add another test for the fix. bpo-29587: Add another test for the gen.throw() exception chain fix May 2, 2020
@cjerdonek
cjerdonek force-pushed the issue-29587-another-test branch from aa3ff76 to 649401d Compare May 3, 2020 07:13
@cjerdonek

cjerdonek commented May 3, 2020

Copy link
Copy Markdown
Member Author

Rebased after merging PR #19877.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@cjerdonek
cjerdonek force-pushed the issue-29587-another-test branch from 649401d to b4cf70f Compare May 8, 2020 09:24
@cjerdonek
cjerdonek force-pushed the issue-29587-another-test branch 2 times, most recently from baed425 to dd6f901 Compare May 17, 2020 02:14
@cjerdonek
bpo-29587: Add another test for the fix.
dd6f901
@cjerdonek
cjerdonek merged commit d7184d3 into python:master May 17, 2020
@bedevere-bot bedevere-bot removed the awaiting core review label May 17, 2020
@cjerdonek
cjerdonek deleted the issue-29587-another-test branch May 17, 2020 04:14
arturoescaip pushed a commit to arturoescaip/cpython that referenced this pull request May 24, 2020
@cjerdonek @arturoescaip
bpo-29587: Add another test for the gen.throw() fix. (pythonGH-19859)
c20bb44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@cjerdonek @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.