GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-39573: Use Py_IS_TYPE to check for types by shihai1991 · Pull Request #19882 · python/cpython

Conversation

@shihai1991

@shihai1991 shihai1991 commented May 3, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

https://bugs.python.org/issue39573

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@shihai1991
Use Py_IS_TYPE to check for types
4051426
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label May 3, 2020
@bedevere-bot bedevere-bot added the awaiting review label May 3, 2020
@shihai1991

shihai1991 commented May 3, 2020

Copy link
Copy Markdown
Member Author

rough idea: Can we create a review robot to remind committer use the common macros or inline functions?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@corona10 corona10 changed the title WIP: Use Py_IS_TYPE to check for types bpo-39573: [WIP] Use Py_IS_TYPE to check for types May 3, 2020
@corona10

corona10 commented May 3, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This PR can be part of bpo-39573 which actually introducing and applying Py_IS_TYPE for the first time.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@corona10 corona10 added the skip news label May 3, 2020
@corona10
corona10 requested a review from vstinner May 3, 2020 12:42
corona10
corona10 approved these changes May 3, 2020
View reviewed changes

@corona10 corona10 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We often do not accept the PR which can be just refactoring work with insignificant reason.
However, this PR is handling module what #18521 did not.
So I approve of this change as the exception.

But we need to hear @vstinner 's opinion :)

Thanks for the work

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels May 3, 2020
@shihai1991

shihai1991 commented May 3, 2020

Copy link
Copy Markdown
Member Author

This PR can be part of bpo-39573 which actually introducing and applying Py_IS_TYPE for the first time.

yeap. You are the author ;)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@shihai1991 shihai1991 changed the title bpo-39573: [WIP] Use Py_IS_TYPE to check for types bpo-39573: Use Py_IS_TYPE to check for types May 3, 2020
@corona10

corona10 commented May 3, 2020

Copy link
Copy Markdown
Member

@shihai1991
But I approve the current change, so if the PR is updated for the more module.
Please request a review again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@shihai1991

shihai1991 commented May 3, 2020

Copy link
Copy Markdown
Member Author

@shihai1991
But I approve the current change, so if the PR is updated for the more module.
Please request a review again.

Thanks, I have checked all modules, there have no more should be ported.
corona10 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@corona10
corona10 merged commit 5e8ffe1 into python:master May 4, 2020
@bedevere-bot bedevere-bot removed the awaiting merge label May 4, 2020
@vstinner vstinner mentioned this pull request Mar 12, 2024
[C API] Avoid accessing PyObject and PyVarObject members directly: add Py_SET_TYPE() and Py_IS_TYPE(), disallow Py_TYPE(obj)=type #83754
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corona10 corona10 corona10 approved these changes
@vstinner vstinner Awaiting requested review from vstinner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@shihai1991 @corona10 @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.