GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.6] bpo-24274: fix erroneous comment in dictobject.c by methane · Pull Request #200 · python/cpython

Conversation

@methane

@methane methane commented Feb 20, 2017

Copy link
Copy Markdown
Member

lookdict_unicode() and lookdict_unicode_nodummy() may raise exception
when key is not unicode.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@methane
bpo-24274: fix erroneous comment in dictobject.c (pythonGH-196)
9f5aabb
lookdict_unicode() and lookdict_unicode_nodummy() may raise exception
when key is not unicode.
@methane methane added the cherry-pick for 3.6 label Feb 20, 2017
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Feb 20, 2017
zhangyangyu
zhangyangyu approved these changes Feb 20, 2017
View reviewed changes
@methane
methane merged commit ce552e2 into python:3.6 Feb 20, 2017
@methane
methane deleted the fix-dict-comment branch February 20, 2017 13:58
akruis added a commit to akruis/cpython that referenced this pull request Jan 6, 2019
@akruis
Stackless issue python#200: fix PyTasklet_Run_nr() and PyTasklet_Swit…
3629160
…ch_nr()

Fix a bug in the C-API functions PyTasklet_Run_nr() and
PyTasklet_Switch_nr(). Under exotic conditions the functions could
cause undefined behavior.
akruis added a commit to akruis/cpython that referenced this pull request Jan 20, 2019
@akruis
Stackless issue python#200: fix PyTasklet_Run_nr() and PyTasklet_Swit…
5cbfbe2
…ch_nr()

Fix a bug in the C-API functions PyTasklet_Run_nr() and
PyTasklet_Switch_nr(). Under exotic conditions the functions could
cause undefined behavior.

(cherry picked from commit 3629160)
akruis added a commit to akruis/cpython that referenced this pull request Feb 18, 2019
@akruis
Stackless issue python#200: fix PyTasklet_Run_nr() and PyTasklet_Swit…
1c4c312
…ch_nr()

Fix a bug in the C-API functions PyTasklet_Run_nr() and
PyTasklet_Switch_nr(). Under exotic conditions the functions could
cause undefined behavior.

(cherry picked from commit 3629160)
pablogsal pushed a commit to pablogsal/cpython that referenced this pull request Nov 29, 2022
@isidentical
Handle raw strings with r and R in action helper (python#200)
ca5a54a
jaraco pushed a commit that referenced this pull request Dec 2, 2022
@pyup-bot @asvetlov
Update aiohttp from 3.5.1 to 3.5.3 (#200)
f34d4f2
SonicField added a commit to SonicField/cpython that referenced this pull request Apr 27, 2026
@SonicField
docs/known-bugs: gen_simple bisect bound REVISED — regression pre-dat…
f6f646a
…es Phase 3D

Per supervisor 2026-04-27T19:31:15Z + theologian 2026-04-27T19:30Z
audit. The bisect bound "Phase-3D-start (42d0a0b)..HEAD" cited in
prior revisions is INCORRECT — gen_simple was already at 0.75x in
docs/benchmarks/x86_64_abba_2026-03-31.md, predating Phase 3D Step 1
(2026-04-01) by 1 day. Companion arm64_abba_2026-04-01.md annotation
hypothesizes "Generator resume path has JIT infrastructure overhead
(deopt trampoline)" as contemporaneous root-cause candidate.

Updates Status section, Stability evidence table (adds 2 pre-Phase-3D
entries + revised range/coverage), and Resumption gate step 2 (revised
bound + deopt-trampoline shortcut candidate). Pythia-python#200/python#202 risk of
bisect resolving inside HirBuilder/Phase-4 surface is reduced — the
introducing commit predates that surface entirely.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhangyangyu zhangyangyu zhangyangyu approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@methane @zhangyangyu @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.