GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.7] [3.8] bpo-40548: GitHub Action workflow: skip jobs on doc only PRs (GH-20100) by miss-islington · Pull Request #20101 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented May 15, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • bpo-40548: Always run GitHub action, even on doc PRs (bpo-40548: Always run GitHub action, even on doc PRs #19981)

Always run GitHub action jobs, even on documentation-only pull
requests. So it will be possible to make a GitHub action job, like
the Windows (64-bit) job, mandatory.

(cherry picked from commit 4e36376)

  • bpo-40548: GitHub Action workflow: skip jobs on doc only PRs (bpo-40548: skip build/tests on documentation changes #19983)

Signed-off-by: Filipe Laíns [email protected]
(cherry picked from commit 75d7257)

  • bpo-40548: github actions: pass the changes check on no source changes (bpo-40548: github actions: pass the changes check on no source changes #20097)

Signed-off-by: Filipe Laíns [email protected]
(cherry picked from commit 6a78589)

Co-authored-by: Filipe Laíns [email protected]
Co-authored-by: Filipe Laíns [email protected]
(cherry picked from commit 07bd5cf)

Co-authored-by: Victor Stinner [email protected]

https://bugs.python.org/issue40548

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner @miss-islington
[3.8] bpo-40548: GitHub Action workflow: skip jobs on doc only PRs (p…
1f2d80c 
…ythonGH-20100)

* bpo-40548: Always run GitHub action, even on doc PRs (pythonGH-19981)

Always run GitHub action jobs, even on documentation-only pull
requests. So it will be possible to make a GitHub action job, like
the Windows (64-bit) job, mandatory.

(cherry picked from commit 4e36376)

* bpo-40548: GitHub Action workflow: skip jobs on doc only PRs (pythonGH-19983)

Signed-off-by: Filipe Laíns <[email protected]>
(cherry picked from commit 75d7257)

* bpo-40548: github actions: pass the changes check on no source changes (pythonGH-20097)

Signed-off-by: Filipe Laíns <[email protected]>
(cherry picked from commit 6a78589)

Co-authored-by: Filipe Laíns <[email protected]>
Co-authored-by: Filipe Laíns <[email protected]>
(cherry picked from commit 07bd5cf)

Co-authored-by: Victor Stinner <[email protected]>
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label May 15, 2020
@bedevere-bot bedevere-bot mentioned this pull request May 15, 2020
[3.8] bpo-40548: GitHub Action workflow: skip jobs on doc only PRs #20100
Merged
@bedevere-bot bedevere-bot added skip news awaiting review labels May 15, 2020
vstinner
vstinner approved these changes May 15, 2020
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot. I checked that wit the cherry-pick, 3.7 and master have the same configuration. master also has "push" configuration which is not needed for 3.7 if I understood correctly. (Same difference in 3.8.)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels May 15, 2020
@miss-islington

miss-islington commented May 15, 2020

Copy link
Copy Markdown
Contributor Author

@vstinner: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington
miss-islington merged commit 6ad51a1 into python:3.7 May 15, 2020
@bedevere-bot bedevere-bot removed the awaiting merge label May 15, 2020
@miss-islington
miss-islington deleted the backport-07bd5cf-3.7 branch May 15, 2020 03:46
@miss-islington

miss-islington commented May 15, 2020

Copy link
Copy Markdown
Contributor Author

@vstinner: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@miss-islington @vstinner @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.