GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.8] bpo-40548: GitHub Action workflow: skip jobs on doc only PRs by vstinner · Pull Request #20100 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented May 15, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

https://bugs.python.org/issue40548

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
vstinner and others added 3 commits May 15, 2020 05:05
@vstinner
bpo-40548: Always run GitHub action, even on doc PRs (GH-19981)
9be87c1 
Always run GitHub action jobs, even on documentation-only pull
requests. So it will be possible to make a GitHub action job, like
the Windows (64-bit) job, mandatory.

(cherry picked from commit 4e36376)
@FFY00 @vstinner
bpo-40548: GitHub Action workflow: skip jobs on doc only PRs (GH-19983)
dce8144 
Signed-off-by: Filipe Laíns <[email protected]>
(cherry picked from commit 75d7257)
@FFY00 @vstinner
bpo-40548: github actions: pass the changes check on no source changes (
0a66eb2 
GH-20097)

Signed-off-by: Filipe Laíns <[email protected]>
(cherry picked from commit 6a78589)
@vstinner vstinner added the skip news label May 15, 2020
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label May 15, 2020
@bedevere-bot bedevere-bot added the awaiting core review label May 15, 2020
@vstinner

vstinner commented May 15, 2020

Copy link
Copy Markdown
Member Author

As proposed by @Mariatta at python/core-workflow#368 (comment) I backport the GitHub Action workflow configuration from master to 3.8.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner merged commit 07bd5cf into python:3.8 May 15, 2020
@bedevere-bot bedevere-bot removed the awaiting core review label May 15, 2020
@vstinner
vstinner deleted the gha_doconly branch May 15, 2020 03:27
@vstinner vstinner added the needs backport to 3.7 label May 15, 2020
@miss-islington

miss-islington commented May 15, 2020

Copy link
Copy Markdown
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 15, 2020
@vstinner @miss-islington
[3.8] bpo-40548: GitHub Action workflow: skip jobs on doc only PRs (p…
1f2d80c 
…ythonGH-20100)

* bpo-40548: Always run GitHub action, even on doc PRs (pythonGH-19981)

Always run GitHub action jobs, even on documentation-only pull
requests. So it will be possible to make a GitHub action job, like
the Windows (64-bit) job, mandatory.

(cherry picked from commit 4e36376)

* bpo-40548: GitHub Action workflow: skip jobs on doc only PRs (pythonGH-19983)

Signed-off-by: Filipe Laíns <[email protected]>
(cherry picked from commit 75d7257)

* bpo-40548: github actions: pass the changes check on no source changes (pythonGH-20097)

Signed-off-by: Filipe Laíns <[email protected]>
(cherry picked from commit 6a78589)

Co-authored-by: Filipe Laíns <[email protected]>
Co-authored-by: Filipe Laíns <[email protected]>
(cherry picked from commit 07bd5cf)

Co-authored-by: Victor Stinner <[email protected]>
@bedevere-bot

bedevere-bot commented May 15, 2020

Copy link
Copy Markdown

GH-20101 is a backport of this pull request to the 3.7 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.7 label May 15, 2020
miss-islington added a commit that referenced this pull request May 15, 2020
@miss-islington @vstinner
[3.8] bpo-40548: GitHub Action workflow: skip jobs on doc only PRs (G…
6ad51a1 
…H-20100)

* bpo-40548: Always run GitHub action, even on doc PRs (GH-19981)

Always run GitHub action jobs, even on documentation-only pull
requests. So it will be possible to make a GitHub action job, like
the Windows (64-bit) job, mandatory.

(cherry picked from commit 4e36376)

* bpo-40548: GitHub Action workflow: skip jobs on doc only PRs (GH-19983)

Signed-off-by: Filipe Laíns <[email protected]>
(cherry picked from commit 75d7257)

* bpo-40548: github actions: pass the changes check on no source changes (GH-20097)

Signed-off-by: Filipe Laíns <[email protected]>
(cherry picked from commit 6a78589)

Co-authored-by: Filipe Laíns <[email protected]>
Co-authored-by: Filipe Laíns <[email protected]>
(cherry picked from commit 07bd5cf)

Co-authored-by: Victor Stinner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@vstinner @miss-islington @bedevere-bot @the-knights-who-say-ni @FFY00
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.