GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-40608: restore protection against double-deallocate issue for subclasses of classes that use trashcan by iritkatriel · Pull Request #20104 · python/cpython

Conversation

@iritkatriel

@iritkatriel iritkatriel commented May 15, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Added a unit test that segfaults in python 3.8 and reversed the changes in typeobject.c that caused this segfault.

The segfault occurs with the old trashcan macros (Py_TRASHCAN_SAFE_BEGIN/END) and can be avoided by using the new ones (Py_TRASHCAN_BEGIN/END). The purpose of this change is to prevent segfaults in old code, it can be reversed once the old macros are removed.

https://bugs.python.org/issue40608

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@iritkatriel
bpo-40608: restore protection against double-deallocate issue for sub…
3e076d6 
…classes of classes that use trashcan
@the-knights-who-say-ni

the-knights-who-say-ni commented May 15, 2020

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@iritkatriel

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@the-knights-who-say-ni the-knights-who-say-ni added the CLA not signed label May 15, 2020
@bedevere-bot bedevere-bot added the awaiting review label May 15, 2020
@csabella csabella removed the CLA not signed label Jul 20, 2020
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jul 20, 2020
@csabella
csabella requested review from encukou and vstinner July 20, 2020 11:49
@ambv

ambv commented Aug 27, 2021

Copy link
Copy Markdown
Contributor

Closing in favor of GH-27693. See BPO-44874 and the linked mailing list thread for details.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ambv ambv closed this Aug 27, 2021
@iritkatriel
iritkatriel deleted the trashcan-regression branch October 18, 2022 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner Awaiting requested review from vstinner
@encukou encukou Awaiting requested review from encukou

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@iritkatriel @the-knights-who-say-ni @ambv @csabella @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.