GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-44874: deprecate Py_TRASHCAN_SAFE_BEGIN and Py_TRASHCAN_SAFE_END by iritkatriel · Pull Request #27693 · python/cpython

Conversation

@iritkatriel

@iritkatriel iritkatriel commented Aug 9, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

https://bugs.python.org/issue44874

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@iritkatriel
bpo-44874: deprecate Py_TRASHCAN_SAFE_BEGIN and Py_TRASHCAN_SAFE_END
6772bdf
@iritkatriel
iritkatriel requested review from ambv and pablogsal August 9, 2021 19:03
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Aug 9, 2021
@bedevere-bot bedevere-bot added the awaiting core review label Aug 9, 2021
blurb-it Bot and others added 3 commits August 9, 2021 19:05
@blurb-it
📜🤖 Added by blurb_it.
62d64e7
@iritkatriel
add compiler warning
d4de5cd
@iritkatriel
add migration instructions to news file
f58b627
vstinner
vstinner reviewed Aug 18, 2021
View reviewed changes
Comment thread Misc/NEWS.d/next/Core and Builtins/2021-08-09-19-05-20.bpo-44874.oOcfU4.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
vstinner
vstinner reviewed Aug 18, 2021
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the nice explanation on how to port existing code!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Misc/NEWS.d/next/Core and Builtins/2021-08-09-19-05-20.bpo-44874.oOcfU4.rst Outdated

To support older python versions in the same codebase, you
can define the following macros and use them throughout
the code (credit: these were copied from the ``mypy`` codebase)::

@vstinner vstinner Aug 18, 2021

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like mypy is released under the MIT license: https://github.com/python/mypy/blob/master/LICENSE

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@ambv ambv Aug 18, 2021

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this impact the example?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Misc/NEWS.d/next/Core and Builtins/2021-08-09-19-05-20.bpo-44874.oOcfU4.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
ambv and others added 2 commits August 18, 2021 21:10
@ambv @vstinner
Increase example readability
dc5cd34 
Co-authored-by: Victor Stinner <[email protected]>
@ambv
Move porting instructions to What's New in Python 3.11
9d2d76d
@ambv
ambv merged commit 31ee985 into python:main Aug 18, 2021
@bedevere-bot bedevere-bot removed the awaiting core review label Aug 18, 2021
This was referenced Aug 27, 2021
bpo-35983: improve and test old trashcan macros #12607
Closed
bpo-40608: restore protection against double-deallocate issue for subclasses of classes that use trashcan #20104
Closed
@iritkatriel
iritkatriel deleted the bpo-44874 branch November 5, 2021 09:57
@iritkatriel iritkatriel mentioned this pull request May 30, 2023
Remove deprecated Py_TRASHCAN_SAFE_BEGIN/ Py_TRASHCAN_SAFE_END #105111
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner left review comments
@ambv ambv Awaiting requested review from ambv
@pablogsal pablogsal Awaiting requested review from pablogsal

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@iritkatriel @ambv @vstinner @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.