GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-40656: Clean up detect_socket() by erlend-aasland · Pull Request #20148 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented May 17, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

https://bugs.python.org/issue40656

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label May 17, 2020
@bedevere-bot bedevere-bot added the awaiting review label May 17, 2020
@erlend-aasland

erlend-aasland commented May 17, 2020

Copy link
Copy Markdown
Contributor Author

Ref. discussion in #19526, @ned-deily.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland
erlend-aasland force-pushed the fix-issue-40656 branch from e7ca986 to 293f4c9 Compare May 17, 2020 08:48
Erlend E. Aasland
bpo-40656: Clean up detect_socket()
65eb3fb
@erlend-aasland
erlend-aasland force-pushed the fix-issue-40656 branch from 293f4c9 to 65eb3fb Compare November 17, 2020 12:02
@erlend-aasland

erlend-aasland commented Nov 17, 2020

Copy link
Copy Markdown
Contributor Author

@ned-deily would you mind taking a look at this?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ned-deily
ned-deily approved these changes Nov 18, 2020
View reviewed changes

@ned-deily ned-deily left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much cleaner, thanks. I think we can dispense with a news entry for this.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland reacted with hooray emoji
All reactions
  • 🎉 1 reaction
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Nov 18, 2020
@ned-deily ned-deily added awaiting review skip news and removed awaiting merge labels Nov 18, 2020
@ned-deily
ned-deily merged commit ccdcb20 into python:master Nov 18, 2020
@bedevere-bot bedevere-bot removed the awaiting review label Nov 18, 2020
@erlend-aasland
erlend-aasland deleted the fix-issue-40656 branch November 18, 2020 00:13
@erlend-aasland

erlend-aasland commented Nov 18, 2020

Copy link
Copy Markdown
Contributor Author

Thanks for reviewing, @ned-deily !
ned-deily reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
Erlend Egeberg Aasland @adorilson
bpo-40656: Clean up detect_socket() (pythonGH-20148)
3c9bfa2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ned-deily ned-deily ned-deily approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@erlend-aasland @ned-deily @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.