GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-39573: Convert Py_TYPE() to a static inline function by corona10 · Pull Request #20290 · python/cpython

Conversation

@corona10

@corona10 corona10 commented May 21, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

https://bugs.python.org/issue39573

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label May 21, 2020
@bedevere-bot bedevere-bot added the awaiting core review label May 21, 2020
@corona10
bpo-39573: Convert Py_TYPE() to a static inline function
21dd58e
@corona10
corona10 force-pushed the bpo-39573-py-type branch from 96018cd to 21dd58e Compare May 21, 2020 15:45
@corona10
corona10 requested a review from vstinner May 21, 2020 15:59
vstinner
vstinner reviewed May 22, 2020
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh right, I was waiting for Python 3.10 to do this change.

cc @nascheme

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Doc/c-api/structures.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@corona10
bpo-39573: Update docs
8e9637a
@corona10

corona10 commented May 22, 2020

Copy link
Copy Markdown
Member Author

@vstinner Updated!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@corona10
corona10 requested a review from vstinner May 22, 2020 15:06
vstinner
vstinner reviewed May 25, 2020
View reviewed changes
Comment thread Doc/whatsnew/3.10.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/whatsnew/3.10.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@corona10
bpo-39573: Apply code review
a8b98db
@corona10
corona10 force-pushed the bpo-39573-py-type branch from b89669c to a8b98db Compare May 25, 2020 16:04
vstinner
vstinner reviewed May 25, 2020
View reviewed changes
Comment thread Doc/whatsnew/3.10.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/c-api/structures.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
corona10 and others added 2 commits May 26, 2020 01:11
@corona10 @vstinner
Update Doc/whatsnew/3.10.rst
4306ac8 
Co-authored-by: Victor Stinner <[email protected]>
@corona10 @vstinner
Update Doc/c-api/structures.rst
cd3c677 
Co-authored-by: Victor Stinner <[email protected]>
vstinner
vstinner reviewed May 25, 2020
View reviewed changes
Comment thread Include/object.h Resolved

Uh oh!

There was an error while loading. Please reload this page.
vstinner
vstinner approved these changes May 25, 2020
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. My comments about "const" can be addressed in a separated PR.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Doc/c-api/structures.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels May 25, 2020
@corona10
bpo-39573: Apply code review
7757af5
@corona10
corona10 merged commit ad3252b into python:master May 25, 2020
@bedevere-bot bedevere-bot removed the awaiting merge label May 25, 2020
@tacaswell tacaswell mentioned this pull request May 28, 2020
MAINT: support python 3.10 numpy/numpy#16417
Merged
tacaswell added a commit to tacaswell/numpy that referenced this pull request May 29, 2020
@tacaswell
MNT: support python 3.10
405c6de 
In python/cpython#20290 CPython changed
`Py_TYPE` from a macro to an inline function.  This requires a code
change to us `Py_SET_TYPE` instead when using `Py_TYPE()` as a lvalue
in c code.

In python/cpython#20429 CPython changed
`Py_SIZE` from a macro to an inline function.  This requires a code
change to us `Py_SET_SIZE` instead of using `Py_SIZE` as a lvalue in c
code.
tacaswell added a commit to tacaswell/pycurl that referenced this pull request May 29, 2020
@tacaswell
MNT: support py310
a5312df 
There was a change in the CPython c-api to change `Py_TYPE` from a
macro to an inline
function (python/cpython#20290).  This
requires a change to using `Py_SET_TYPE` which was introduced on
py39a4.
@tacaswell tacaswell mentioned this pull request May 29, 2020
Mnt py310 compat pycurl/pycurl#636
Closed
charris pushed a commit to charris/numpy that referenced this pull request May 29, 2020
@tacaswell @charris
MNT: support python 3.10
0e58c3c 
In python/cpython#20290 CPython changed
`Py_TYPE` from a macro to an inline function.  This requires a code
change to us `Py_SET_TYPE` instead when using `Py_TYPE()` as a lvalue
in c code.

In python/cpython#20429 CPython changed
`Py_SIZE` from a macro to an inline function.  This requires a code
change to us `Py_SET_SIZE` instead of using `Py_SIZE` as a lvalue in c
code.
@charris charris mentioned this pull request May 29, 2020
MAINT: support python 3.10 numpy/numpy#16437
Merged
@vstinner vstinner mentioned this pull request Jun 3, 2021
bpo-39573: Py_TYPE becomes a static inline function #26493
Merged
cielavenir pushed a commit to cielavenir/numpy that referenced this pull request Aug 9, 2023
@tacaswell @cielavenir
MNT: support python 3.10
86e96a0 
In python/cpython#20290 CPython changed
`Py_TYPE` from a macro to an inline function.  This requires a code
change to us `Py_SET_TYPE` instead when using `Py_TYPE()` as a lvalue
in c code.

In python/cpython#20429 CPython changed
`Py_SIZE` from a macro to an inline function.  This requires a code
change to us `Py_SET_SIZE` instead of using `Py_SIZE` as a lvalue in c
code.
cielavenir pushed a commit to cielavenir/numpy that referenced this pull request Aug 22, 2023
@tacaswell @cielavenir
MNT: support python 3.10
3a863bf 
In python/cpython#20290 CPython changed
`Py_TYPE` from a macro to an inline function.  This requires a code
change to us `Py_SET_TYPE` instead when using `Py_TYPE()` as a lvalue
in c code.

In python/cpython#20429 CPython changed
`Py_SIZE` from a macro to an inline function.  This requires a code
change to us `Py_SET_SIZE` instead of using `Py_SIZE` as a lvalue in c
code.
@vstinner vstinner mentioned this pull request Mar 12, 2024
[C API] Avoid accessing PyObject and PyVarObject members directly: add Py_SET_TYPE() and Py_IS_TYPE(), disallow Py_TYPE(obj)=type #83754
Closed
cielavenir pushed a commit to cielavenir/numpy that referenced this pull request Nov 5, 2025
@tacaswell @cielavenir
MNT: support python 3.10
7ea5729 
In python/cpython#20290 CPython changed
`Py_TYPE` from a macro to an inline function.  This requires a code
change to us `Py_SET_TYPE` instead when using `Py_TYPE()` as a lvalue
in c code.

In python/cpython#20429 CPython changed
`Py_SIZE` from a macro to an inline function.  This requires a code
change to us `Py_SET_SIZE` instead of using `Py_SIZE` as a lvalue in c
code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@corona10 @vstinner @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.