GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-40780: Fix failure of _Py_dg_dtoa to remove trailing zeros by mdickinson · Pull Request #20435 · python/cpython

bpo-40780: Fix failure of _Py_dg_dtoa to remove trailing zeros #20435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mdickinson merged 5 commits into python:master from mdickinson:fix-g-mode-trailing-zero
May 29, 2020

Uh oh!

There was an error while loading. Please reload this page.
Merged

bpo-40780: Fix failure of _Py_dg_dtoa to remove trailing zeros #20435

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b6ffd2e
Fix failure of _Py_dg_dtoa to remove trailing zeros
mdickinson May 26, 2020
589da50
Add regression test and news entry
mdickinson May 26, 2020
e9a13a1
Add explanation about why it's safe to strip trailing zeros
mdickinson May 26, 2020
5773e56
Make code safer, clean up comments, add change note at top of file
mdickinson May 27, 2020
556f7dd
Nitpick: avoid implicit int-to-float conversion in tests
mdickinson May 27, 2020
File filter
Filter by extension
Clear filters
Conversations
Failed to load comments.
Loading

Uh oh!

There was an error while loading. Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading

Uh oh!

There was an error while loading. Please reload this page.
Diff view
Diff view
Prev Previous commit
Next Next commit
Add regression test and news entry
  • Loading branch information

Uh oh!

There was an error while loading. Please reload this page.

@mdickinson
mdickinson committed May 26, 2020
commit 589da50d7ffe71c7ffadfdd2b0a4b1c8be16fb12

There are no files selected for viewing

11 changes: 11 additions & 0 deletions 11 Lib/test/test_format.py
Show comments
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -484,6 +484,17 @@ def test_precision_c_limits(self):
with self.assertRaises(ValueError) as cm:
format(c, ".%sf" % (INT_MAX + 1))

def test_g_format_has_no_trailing_zeros(self):
# regression test for bugs.python.org/issue40780
self.assertEqual("%.3g" % 1505, "1.5e+03")
self.assertEqual("%#.3g" % 1505, "1.50e+03")

self.assertEqual(format(1505, ".3g"), "1.5e+03")
self.assertEqual(format(1505, "#.3g"), "1.50e+03")

self.assertEqual(format(12300050, ".6g"), "1.23e+07")
self.assertEqual(format(12300050, "#.6g"), "1.23000e+07")


if __name__ == "__main__":
unittest.main()
2 changes: 2 additions & 0 deletions 2 Misc/NEWS.d/next/Core and Builtins/2020-05-26-17-43-58.bpo-40780.3Ckdgm.rst
Show comments
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Fix a corner case where g-style string formatting of a float failed to
remove trailing zeros.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.