GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-32604: Fix reference leak in select module by vstinner · Pull Request #20600 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Jun 2, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Fix reference leak in PyInit_select() of the select module:
remove Py_INCREF(poll_Type).

https://bugs.python.org/issue32604

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
bpo-32604: Fix reference leak in select module
35240b7 
Fix reference leak in PyInit_select() of the select module:
remove Py_INCREF(poll_Type).
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jun 2, 2020
@bedevere-bot bedevere-bot added the awaiting core review label Jun 2, 2020
@vstinner

vstinner commented Jun 2, 2020

Copy link
Copy Markdown
Member Author

@corona10 @shihai1991: Would you mind to review this fix?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
nanjekyejoannah
nanjekyejoannah reviewed Jun 3, 2020
View reviewed changes

@nanjekyejoannah nanjekyejoannah left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to see if, with this patch, I could solve the refleaks we have been discussing @vstinner on subinterpreters but I can still see the leaks. Am I missing something? Looks like you said you got a success on your end.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner

vstinner commented Jun 3, 2020

Copy link
Copy Markdown
Member Author

I tried to see if, with this patch, I could solve the refleaks we have been discussing @vstinner on subinterpreters but I can still see the leaks. Am I missing something? Looks like you said you got a success on your end.

Which commit did you try? Did you rebase the commit? I used the commit 9d17cbf.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@shihai1991

shihai1991 commented Jun 3, 2020

Copy link
Copy Markdown
Member

I have run your test in my vm, it have been fixed, thanks.

$ ./python -m test -R 3:3 test_subinterpreters
0:00:00 load avg: 0.76 Run tests sequentially
0:00:00 load avg: 0.76 [1/1] test_subinterpreters
beginning 6 repetitions
123456
......

== Tests result: SUCCESS ==

1 test OK.

Total duration: 465 ms
Tests result: SUCCESS
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
shihai1991
shihai1991 approved these changes Jun 3, 2020
View reviewed changes
corona10
corona10 approved these changes Jun 3, 2020
View reviewed changes

@corona10 corona10 left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well I 've run the test code on my local and I detect the current master branch is leaked
and this PR fixes the issue.

   def test_bpo_32604(self):
        code = f"""import select
a = select.poll()
        """
        ret = test.support.run_in_subinterp(code)
        self.assertEqual(ret, 0)

Thanks for the work @vstinner

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner reacted with hooray emoji
All reactions
  • 🎉 1 reaction
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jun 3, 2020
@vstinner

vstinner commented Jun 3, 2020

Copy link
Copy Markdown
Member Author

@nanjekyejoannah:

I tried to see if, with this patch, I could solve the refleaks we have been discussing @vstinner on subinterpreters but I can still see the leaks. Am I missing something? Looks like you said you got a success on your end.

I talked to Joannah in private and she just used the wrong command to test the fix :-)

@corona10:

Well I 've run the test code on my local and I detect the current master branch is leaked
and this PR fixes the issue.

Thanks for this nice manual test!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner merged commit 18a9024 into python:master Jun 3, 2020
@bedevere-bot bedevere-bot removed the awaiting merge label Jun 3, 2020
@vstinner
vstinner deleted the fix_select_leak branch June 3, 2020 12:36
@nanjekyejoannah

nanjekyejoannah commented Jun 3, 2020

Copy link
Copy Markdown
Contributor

Yes, I confirmed with the correct command and this fixes the leak. Thanks @vstinner
vstinner reacted with laugh emoji
All reactions
  • 😄 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nanjekyejoannah nanjekyejoannah mentioned this pull request Jun 3, 2020
bpo-32604: Recommit "bpo-32604: PEP 554 for use in test suite (GH-19985)" #20611
Merged
@ericsnowcurrently ericsnowcurrently mentioned this pull request Apr 10, 2022
[subinterpreters] PEP 554 implementation: add interpreters module #76785
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nanjekyejoannah nanjekyejoannah nanjekyejoannah left review comments
@corona10 corona10 corona10 approved these changes
@shihai1991 shihai1991 shihai1991 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@vstinner @shihai1991 @nanjekyejoannah @corona10 @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.