GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-40862: Raise TypeError when const is given to argparse.BooleanOptionalAction by remilapeyre · Pull Request #20623 · python/cpython

Conversation

@remilapeyre

@remilapeyre remilapeyre commented Jun 4, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

https://bugs.python.org/issue40862

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Rémi Lapeyre
Raise TypeError when const is given to argparse.BooleanOptionalAction
053640c
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jun 4, 2020
@bedevere-bot bedevere-bot added the awaiting review label Jun 4, 2020
@remilapeyre remilapeyre mentioned this pull request Jun 4, 2020
bpo-8538: Add support for boolean actions to argparse #11478
Merged
hauntsaninja
hauntsaninja approved these changes Jun 4, 2020
View reviewed changes

@hauntsaninja hauntsaninja left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, lgtm apart from comment nit

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Lib/test/test_argparse.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added awaiting core review and removed awaiting review labels Jun 4, 2020
Rémi Lapeyre @hauntsaninja
Fix bpo number
157c08e 
Co-authored-by: Shantanu <[email protected]>
@rhettinger rhettinger self-assigned this Jun 5, 2020
rhettinger
rhettinger approved these changes Jun 5, 2020
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jun 5, 2020
@rhettinger rhettinger added needs backport to 3.9 skip news labels Jun 5, 2020
@rhettinger
rhettinger merged commit b084d1b into python:master Jun 5, 2020
@miss-islington

miss-islington commented Jun 5, 2020

Copy link
Copy Markdown
Contributor

Thanks @remilapeyre for the PR, and @rhettinger for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Jun 5, 2020
@bedevere-bot

bedevere-bot commented Jun 5, 2020

Copy link
Copy Markdown

GH-20664 is a backport of this pull request to the 3.9 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.9 label Jun 5, 2020
rhettinger pushed a commit that referenced this pull request Jun 6, 2020
@miss-islington
bpo-40862: Raise TypeError when const is given to argparse.BooleanOpt…
d5e7348 
…ionalAction (GH-20623) (GH-20664)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhettinger rhettinger rhettinger approved these changes
@hauntsaninja hauntsaninja hauntsaninja approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@rhettinger rhettinger

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@remilapeyre @miss-islington @bedevere-bot @rhettinger @hauntsaninja @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.