GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-32604: Disable failing tests by nanjekyejoannah · Pull Request #20777 · python/cpython

Conversation

@nanjekyejoannah

@nanjekyejoannah nanjekyejoannah commented Jun 10, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

I decided to skip the tests in question until I get time to fix the races.

Requesting a second eye @pablogsal and @vstinner if this makes the bots green.

https://bugs.python.org/issue32604

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
nanjekyejoannah
Skip tests to fix bot
3bee8d8
@nanjekyejoannah
nanjekyejoannah requested review from pablogsal and vstinner June 10, 2020 12:30
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jun 10, 2020
@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting core review labels Jun 10, 2020
@nanjekyejoannah nanjekyejoannah added the skip news label Jun 10, 2020
ericsnowcurrently
ericsnowcurrently approved these changes Jun 17, 2020
View reviewed changes

@ericsnowcurrently ericsnowcurrently left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I'll see if we can track down the problem by the end of the week and get those tests re-enabled.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jun 17, 2020
@vstinner

vstinner commented Jun 17, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

The PR title is very misleading: "bpo-32604: PEP 554 implementation: add interpreters module #20777".
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nanjekyejoannah nanjekyejoannah changed the title bpo-32604: PEP 554 implementation: add interpreters module bpo-32604: Disable failing tests Jun 17, 2020
@nanjekyejoannah
nanjekyejoannah merged commit 6f79838 into python:master Jun 21, 2020
@bedevere-bot bedevere-bot removed the awaiting merge label Jun 21, 2020
@nanjekyejoannah

nanjekyejoannah commented Jun 22, 2020

Copy link
Copy Markdown
Contributor Author

Merging until we get a fix @ericsnowcurrently
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
fasih pushed a commit to fasih/cpython that referenced this pull request Jun 29, 2020
@nanjekyejoannah nanjekyejoannah @fasihahmad
Skip tests to fix bot (pythonGH-20777)
69b3080 
Co-authored-by: nanjekyejoannah <[email protected]>
@ericsnowcurrently ericsnowcurrently mentioned this pull request Apr 10, 2022
[subinterpreters] PEP 554 implementation: add interpreters module #76785
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes
@vstinner vstinner Awaiting requested review from vstinner
@pablogsal pablogsal Awaiting requested review from pablogsal

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@nanjekyejoannah @vstinner @ericsnowcurrently @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.