GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-40989: Move _Py_NewReference() to the internal C API by vstinner · Pull Request #20904 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Jun 15, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Remove the _Py_NewReference() function from the public C API (move it
to the internal C API).

https://bugs.python.org/issue40989

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
vstinner requested review from 1st1 and asvetlov as code owners June 15, 2020 23:53
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jun 15, 2020
@bedevere-bot bedevere-bot added the awaiting core review label Jun 15, 2020
@vstinner

vstinner commented Jun 15, 2020

Copy link
Copy Markdown
Member Author

I ran a quick test on Cython, numpy and lxml: all projects 3 builds successful. I had to backport a few patches for numpy, to fix another unrelated incompatible changes. I didn't run their test suite.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Jun 16, 2020

Copy link
Copy Markdown
Member Author

I completed my PR to remove more functions:

  • _Py_NewReference()
  • _Py_ForgetReference()
  • _Py_GetRefTotal()
  • _PyTraceMalloc_NewReference()
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
bpo-40989: Move _Py_NewReference() to the internal C API
57179aa 
Remove the _Py_NewReference() and _Py_ForgetReference() functions
from the public C API: move them to the internal C API.

Move with_tp_del() test function from the _testcapi module to the
_testinternalcapi module.
@vstinner

vstinner commented Jun 16, 2020

Copy link
Copy Markdown
Member Author

This PR now only makes two (related) functions internals:

  • _Py_NewReference()
  • _Py_ForgetReference()

I rebased this PR on top of PR #20915 which made _PyTraceMalloc_NewReference() fully internal (don't export it anymore).

I changed my mind on _Py_GetRefTotal(): for now, it's fine to keep it as a private function, since sys._gettotalrefcount() private function exists at the Python level.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner closed this Sep 21, 2021
@vstinner
vstinner deleted the make_new_ref_internal branch September 21, 2021 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@vstinner @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.