GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-40989: Make _PyTraceMalloc_NewReference() internal by vstinner · Pull Request #20915 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Jun 16, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Make the _PyTraceMalloc_NewReference() function fully internal:
remove it from the public C API and don't export it anymore.

https://bugs.python.org/issue40989

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
bpo-40989: Make _PyTraceMalloc_NewReference() internal
757c82b 
Make the _PyTraceMalloc_NewReference() function fully internal:
remove it from the public C API and don't export it anymore.
@vstinner vstinner added the skip news label Jun 16, 2020
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jun 16, 2020
@bedevere-bot bedevere-bot added the awaiting core review label Jun 16, 2020
@vstinner

vstinner commented Jun 16, 2020

Copy link
Copy Markdown
Member Author

At the second build, the 3 mandatory Travis CI jobs passed, but I have to wait until the two optional coverage jobs are running before being able to merge.

I created https://bugs.python.org/issue40993 "Don't run Python and C coverage jobs of Travis CI on pull requests" to be able to merge PRs faster.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner merged commit fcc60e4 into python:master Jun 16, 2020
@bedevere-bot bedevere-bot removed the awaiting core review label Jun 16, 2020
@vstinner
vstinner deleted the make_tracenew_ref_internal branch June 16, 2020 15:30
@vstinner vstinner mentioned this pull request Jun 16, 2020
bpo-40989: Move _Py_NewReference() to the internal C API #20904
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@vstinner @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.