GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-36346: Make unicodeobject.h C89 compatible by methane · Pull Request #20934 · python/cpython

Conversation

@methane

@methane methane commented Jun 17, 2020 •
edited by miss-islington
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

https://bugs.python.org/issue36346

Automerge-Triggered-By: @methane

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@methane
fix buildbots
8b54cb7
@methane methane added type-bug An unexpected behavior, bug, or error skip news labels Jun 17, 2020
@methane
methane requested a review from vstinner June 17, 2020 12:31
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jun 17, 2020
@methane methane added 🔨 test-with-buildbots Test PR w/ buildbots; report in status section and removed CLA signed labels Jun 17, 2020
@bedevere-bot

bedevere-bot commented Jun 17, 2020

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @methane for commit 8b54cb7 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added the awaiting core review label Jun 17, 2020
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jun 17, 2020
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 17, 2020
vstinner
vstinner approved these changes Jun 17, 2020
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But I suggest to change the commit title to "Make unicodeobject.h C89 compatible".

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Include/cpython/unicodeobject.h
Py_UNICODE_FILL(Py_UNICODE *target, Py_UNICODE value, Py_ssize_t length) {
for (Py_ssize_t i = 0; i < length; i++) {
Py_ssize_t i;
for (i = 0; i < length; i++) {

@vstinner vstinner Jun 17, 2020

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change makes me sad :-( But well, as I wrote in the issue, I think that it's a good practice to try to keep C89 support for the public C API.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jun 17, 2020
@methane methane changed the title bpo-36346: Fix buildbots bpo-36346: Make unicodeobject.h C89 compatible Jun 17, 2020
@methane methane added the 🤖 automerge label Jun 17, 2020
@methane
methane merged commit 8e34e92 into python:master Jun 17, 2020
@methane
methane deleted the fix-buildbot branch June 17, 2020 14:43
@bedevere-bot bedevere-bot removed the awaiting merge label Jun 17, 2020
methane added a commit to methane/cpython that referenced this pull request Jun 17, 2020
@methane
bpo-36346: Make unicodeobject.h C89 compatible (pythonGH-20934)
5fc4e4b
@bedevere-bot bedevere-bot mentioned this pull request Apr 10, 2022
Prepare for removing the legacy Unicode C API #80527
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@methane @bedevere-bot @vstinner @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.