GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-40077: Convert _bz2 module to use PyType_FromSpec by corona10 · Pull Request #20960 · python/cpython

Conversation

@corona10

@corona10 corona10 commented Jun 18, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

https://bugs.python.org/issue40077

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@corona10
bpo-40077: Convert _bz2 module to use PyType_FromSpec
a45739f
@corona10 corona10 added the DO-NOT-MERGE label Jun 18, 2020
@corona10
corona10 requested a review from vstinner June 18, 2020 10:05
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jun 18, 2020
@bedevere-bot bedevere-bot added the awaiting core review label Jun 18, 2020
corona10
corona10 commented Jun 18, 2020
View reviewed changes
Comment thread Lib/test/test_bz2.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@corona10
corona10 marked this pull request as draft June 18, 2020 13:15
@corona10 corona10 removed the DO-NOT-MERGE label Jun 18, 2020
@vstinner

vstinner commented Jun 18, 2020

Copy link
Copy Markdown
Member

I don't think that it should be possible to serialize a Compressor or Decompressor object. There is no getstate/setstate or reduce methods which would serialize attributes only accessible in C. More generally, I don't think that it would be useful, nor needed.

See https://bugs.python.org/issue40077#msg371813
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@corona10
bpo-40077: Re-enable pickle test
fcc9726
vstinner
vstinner reviewed Jun 18, 2020
View reviewed changes
Comment thread Modules/_bz2module.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
corona10 added 2 commits June 19, 2020 02:02
@corona10
bpo-40077: nit fix
e1e4c4a
@corona10
bpo-40077: Apply code review
54d233c
@corona10
corona10 marked this pull request as ready for review June 18, 2020 17:04
@corona10
bpo-40077: fix
498b453
@corona10

corona10 commented Jun 18, 2020

Copy link
Copy Markdown
Member Author

@vstinner Thanks updated!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@corona10
corona10 requested a review from vstinner June 18, 2020 17:06
vstinner
vstinner reviewed Jun 18, 2020
View reviewed changes
Comment thread Modules/_bz2module.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@corona10
bpo-40077: Apply Victor's review
09944c9
vstinner
vstinner reviewed Jun 19, 2020
View reviewed changes
Comment thread Modules/_bz2module.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
corona10 added 2 commits June 19, 2020 23:17
@corona10
bpo-40077: Add Py_tp_traverse
58073f6
@corona10
bpo-40077: fix
043590b
@corona10
corona10 requested a review from vstinner June 19, 2020 14:21
vstinner
vstinner reviewed Jun 19, 2020
View reviewed changes
Comment thread Modules/_bz2module.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/_bz2module.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@corona10
bpo-40077: Apply Victor's review
89ecd25
@corona10
corona10 force-pushed the bpo-40077-bz2 branch from b101416 to 89ecd25 Compare June 19, 2020 14:54
@corona10
corona10 requested a review from vstinner June 19, 2020 14:54
vstinner
vstinner approved these changes Jun 19, 2020
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jun 19, 2020
@corona10 corona10 closed this Jun 19, 2020
@corona10 corona10 reopened this Jun 19, 2020
@corona10
corona10 merged commit ec68918 into python:master Jun 19, 2020
@bedevere-bot bedevere-bot removed the awaiting merge label Jun 19, 2020
@corona10
corona10 deleted the bpo-40077-bz2 branch June 19, 2020 15:56
fasih pushed a commit to fasih/cpython that referenced this pull request Jun 29, 2020
@corona10 @fasihahmad
bpo-40077: Convert _bz2 module to use PyType_FromSpec (pythonGH-20960)
4a9bcd5
@corona10 corona10 mentioned this pull request Jun 27, 2022
Convert static types to heap types: use PyType_FromSpec() #84258
Closed
@sergey-miryanov sergey-miryanov mentioned this pull request Sep 18, 2025
gh-116946: Remove gc-support from some immutable types #139073
Merged
7 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@corona10 @vstinner @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.