GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Update readme by zware · Pull Request #21 · python/cpython

Conversation

@zware

@zware zware commented Feb 11, 2017

Copy link
Copy Markdown
Member

This does some modernization and cleanup of the toplevel README. There is still significant room for improvement, but this hits some of the low-hanging fruit.

For reviewers, the first commit is the real change, the second commit is a simple rewrap.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Feb 11, 2017
Mariatta
Mariatta reviewed Feb 11, 2017
View reviewed changes
Comment thread README.rst Outdated

@Mariatta Mariatta Feb 11, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub with capital H :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@zware zware Feb 11, 2017

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
ezio-melotti
ezio-melotti reviewed Feb 11, 2017
View reviewed changes
Comment thread README.rst Outdated

@ezio-melotti ezio-melotti Feb 11, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This paragraph is a bit harsh, from the uppercase "IMPORTANT" to calling the output of "make test" "useless".

I would rewrite it as:

If the tests fail, you can run the failing test(s) in verbose mode using:
./python -m test -v test_that_failed
You should then file a bug report and include the output of this command.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@zware zware Feb 11, 2017

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, will amend.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@matrixise matrixise Feb 11, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could keep a consistence, ./python -m test -v test_that_failed or make test TESTOPTS="-v" test_that_failed

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@zware zware Feb 12, 2017

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matrixise I'm not sure I understand your point. I switched to make test TESTOPTS="-v test_that_failed" because running the tests is suggested with make test, and there was previously a note about what to do if you built python in a different directory. Reusing make test with TESTOPTS means the different directory question just goes away, but we get exactly the same result.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
matrixise
matrixise reviewed Feb 11, 2017
View reviewed changes
Comment thread README.rst Outdated

@matrixise matrixise Feb 11, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this character ' ?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@pfmoore pfmoore Feb 11, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the possessive form. Maybe a better wording would be "LTO takes advantage of the ability of recent compiler toolchains to optimise..."

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
matrixise reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

@matrixise matrixise Feb 11, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, because I have not seen the possessive form, but just a mistake in the text.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@zware zware Feb 12, 2017

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, this is significantly less than ideal. Fixing it also showed that there's a typo in "takes advantages".

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
berkerpeksag
berkerpeksag approved these changes Feb 11, 2017
View reviewed changes
@berkerpeksag berkerpeksag added the backport to 3.6 label Feb 11, 2017
dstufft
dstufft approved these changes Feb 11, 2017
View reviewed changes
zware added 5 commits February 13, 2017 21:47
@zware
Various updates to README.rst
4fffc3f 
These include spelling/grammar fixes, removing some outdated prose,
updating some superceded prose, and adding/cleaning up some links.
@zware
Rewrap at 80 columns
ca7c4f6 
[skip ci]
@zware
Capitalize the 'H' in GitHub
a5ebe4b
@zware
Soften verbose testing section
5bbcd3a
@zware
Fix awkward construction in LTO section
5a20814 
[skip ci]
@zware
zware force-pushed the update_readme branch from 0d08045 to 5a20814 Compare February 14, 2017 03:58
@codecov

codecov Bot commented Feb 14, 2017

Copy link
Copy Markdown

Codecov Report

Merging #21 into master will decrease coverage by -0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #21      +/-   ##
==========================================
- Coverage   82.38%   82.37%   -0.02%     
==========================================
  Files        1428     1427       -1     
  Lines      351138   350948     -190     
==========================================
- Hits       289291   289087     -204     
- Misses      61847    61861      +14

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b692dc8...5a20814. Read the comment docs.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@zware
zware merged commit d50f188 into python:master Feb 14, 2017
@zware
zware deleted the update_readme branch February 14, 2017 04:01
zware added a commit to zware/cpython that referenced this pull request Feb 14, 2017
@zware
Backport master's README.rst to 3.6
37c0cb7 
Includes GH-2, pythonGH-70, pythonGH-73, and pythonGH-21.
@zware zware mentioned this pull request Feb 14, 2017
Backport master's README.rst to 3.6 #86
Merged
zware added a commit that referenced this pull request Feb 15, 2017
@zware
Backport master's README.rst to 3.6 (GH-86)
1e8cc88 
Includes GH-2, GH-70, GH-73 (GH-79), and GH-21.
@vstinner vstinner mentioned this pull request Feb 15, 2017
Rename Doc/README.txt to Doc/README.rst and add formatting #104
Merged
@Mariatta Mariatta removed the needs backport to 3.6 label Feb 25, 2017
@Mariatta

Mariatta commented Feb 25, 2017

Copy link
Copy Markdown
Member

Backport to 3.5 and 2.7?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Mariatta Mariatta added needs backport to 2.7 labels Feb 25, 2017
@zware zware removed the needs backport to 2.7 label Sep 6, 2017
@pablogsal pablogsal mentioned this pull request Jun 12, 2020
bpo-40958: Avoid buffer overflow in the parser when indexing the current line #20842
Closed
@itachaaa itachaaa mentioned this pull request Aug 22, 2022
Python 3.10 hang at exit in drop_gil() (due to resource warning at exit?) #91414
Closed
@mdboom mdboom mentioned this pull request Aug 25, 2022
Assert and incorrect error message when loading source file containing invalid UTF-8 #96268
Closed
@mdboom mdboom mentioned this pull request Nov 22, 2022
Type punning (and strict aliasing) issue in Py_CLEAR() and Py_SETREF() macros: Python --enable-pystats is miscompiled #99701
Closed
@ziegenbalg ziegenbalg mentioned this pull request Nov 30, 2022
double free in io.TextIOWrapper #72573
Closed
jaraco pushed a commit that referenced this pull request Dec 2, 2022
@Mariatta
random.choice wasn't needed (GH-21)
81e8d6b
nanjekyejoannah added a commit to nanjekyejoannah/cpython that referenced this pull request Feb 16, 2023
@bors @nanjekyejoannah
Merge python#21
50b46c5 
21: warn for keys/items/values/range r=ltratt a=nanjekyejoannah

I think I was over-thinking the solution with flags at synbol table generation. I found a simple check at the AST that checks correctness of values assigned to wanr for things like "True" and other keywords and used this check to warn for these calls.

This warns for `keys/values/items/range`:

Accurate when the statement is in an assignment:

`x = range(20)`
` y = d.keys()`

Co-authored-by: Joannah Nanjekye <[email protected]>
jaraco pushed a commit to jaraco/cpython that referenced this pull request Feb 17, 2023
@warsaw
Add support for multiversion testing with tox (python#21)
a07bc94 
Also full coverage for all supported Pythons.
oraluben pushed a commit to oraluben/cpython that referenced this pull request Jun 25, 2023
@JuliaPoo
fix: wrong offset in BB_BRANCH_IF_FLAG_SET codegen (python#21)
b398fab
@gvanrossum gvanrossum mentioned this pull request Aug 22, 2023
heap-use-after-free in _PyFunction_LookupByVersion #108253
Closed
@LinanV LinanV mentioned this pull request Oct 23, 2023
Objects/typeobject.c: No such file or directory. #111203
Closed
@stasos24 stasos24 mentioned this pull request Oct 24, 2023
Modules/cjkcodecs/_codecs_iso2022.c - read out of bounds #101180
Closed
@williamhu020 williamhu020 mentioned this pull request Nov 5, 2023
Use the API C of 'Py-NewInterpreterFromConfig' to exit unexpectedly in multiple threads. #111751
Closed
@kcatss kcatss mentioned this pull request Nov 15, 2023
Use-after-free in unregister() of atexit module #112127
Closed
@kcatss kcatss mentioned this pull request Jan 14, 2024
crash in long_vectorcall in longobject.c #114050
Closed
@kcatss kcatss mentioned this pull request Feb 12, 2024
Segmentation Fault in pthread_getcpuclockid function in time module #115378
Closed
@kcatss kcatss mentioned this pull request Feb 20, 2024
Use After Free at _heapreplace_max #115706
Closed
@ngoldbaum ngoldbaum mentioned this pull request Sep 23, 2024
Crash running PyO3 tests with --test-threads=1000 #124375
Closed
@Dean6767 Dean6767 mentioned this pull request Feb 10, 2025
🚨 Segmentation Fault in Python 3.10.12 when using OpenSSL (libcrypto.so.3) #129974
Closed
This was referenced Feb 11, 2025
segmentfault when pip installing setuptools #129992
Closed
segmentfault when pip installing setuptools #129993
Closed
@DominiquePACCO DominiquePACCO mentioned this pull request Jun 3, 2025
PdfWriter add_page adds (re)writes old page instead of new #135062
Closed
@efimov-mikhail efimov-mikhail mentioned this pull request Nov 5, 2025
memory leak in threading stack size #141044
Open
youknowone referenced this pull request in youknowone/cpython Nov 25, 2025
@youknowone
Run rustfmt (#21)
e7fe182
StanFromIreland referenced this pull request in StanFromIreland/cpython Dec 6, 2025
@DinoV
Merge pull request #21 from LazyImportsCabal/lazy_rebase
d8f95f7 
Lazy rebase
@sergey-miryanov sergey-miryanov mentioned this pull request Dec 18, 2025
Observed memory leak in ssl library: Python 3.14 GC issue #142516
Closed
@Qanux Qanux mentioned this pull request Feb 11, 2026
heap-buffer-overflow in functools.partial.__repr__() #144475
Closed
@ngoldbaum ngoldbaum mentioned this pull request Mar 6, 2026
Remove deprecated and undocumented function ctypes.SetPointerType #133866
Closed
This was referenced Jul 18, 2026
free threading: struct iter_unpack is not memory safe #154013
Closed
use-after-free: functools partial #154189
Closed
This was referenced Sep 11, 2026
Heap-buffer-overflow in the hz incremental decoder on a trailing ~ #157325
Closed
Heap UAF in io.TextIOWrapper read path via reentrant detach() #157363
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pfmoore pfmoore pfmoore left review comments
@Mariatta Mariatta Mariatta left review comments
@ezio-melotti ezio-melotti ezio-melotti left review comments
@berkerpeksag berkerpeksag berkerpeksag approved these changes
@dstufft dstufft dstufft approved these changes
+1 more reviewer
@matrixise matrixise matrixise left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@zware @Mariatta @berkerpeksag @matrixise @dstufft @pfmoore @ezio-melotti @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.