GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.9] bpo-31938: Fix default-value signatures of several functions in the select module (GH-21066) by asottile · Pull Request #21097 · python/cpython

Conversation

@asottile

@asottile asottile commented Jun 23, 2020 •
edited by miss-islington
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

(cherry picked from commit d051801)

https://bugs.python.org/issue31938

Automerge-Triggered-By: @vstinner

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@asottile
bpo-31938: Fix default-value signatures of several functions in the s…
7f7548e 
…elect module (pythonGH-21066)

(cherry picked from commit d051801)
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jun 23, 2020
@bedevere-bot bedevere-bot mentioned this pull request Jun 23, 2020
bpo-31938: Fix default-value signatures of several functions in the select module #21066
Merged
@bedevere-bot bedevere-bot added the awaiting review label Jun 23, 2020
@asottile asottile mentioned this pull request Jun 23, 2020
automatic conflict resolution for argument clinic generated files? python/cherry-picker#18
Closed
vstinner
vstinner approved these changes Jun 23, 2020
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Jun 23, 2020
@vstinner vstinner added the 🤖 automerge label Jun 23, 2020
@miss-islington

miss-islington commented Jun 23, 2020

Copy link
Copy Markdown
Contributor

@asottile: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington
miss-islington merged commit 48fc35a into python:3.9 Jun 23, 2020
@bedevere-bot bedevere-bot removed the awaiting merge label Jun 23, 2020
@asottile
asottile deleted the backport-d051801-3.9 branch June 23, 2020 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@asottile @miss-islington @vstinner @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.