GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||
GeezerVison is showing github.com — bpo-31938: Fix default-value signatures of several functions in the select module by asottile · Pull Request #21066 · python/cpython Conversation
|
|
If this is the proper way to do it, this PR should also fix the default values for |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Oops, I didn't notice that you proposed a PR and so I wrote PR #21067 which is the same fix :-) Copy of my comment there. inspect.signature() doesn't see the event_mask. Is it a bug in signature which doesn't support a signature written on two lines? cc @serhiy-storchaka @1st1 @ambv So pydoc doesn't show the whole signature: |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
IMO the fix is correct, so I concur thta the two other functions signature should also be fixed. By the way, I suggest to rephase the NEWS entry to explain that the change fix the "signature" rather than fixing "pydoc". |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
8f69adc to
ea850df
Compare
|
I fixed a few others as well -- good catch |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Sorry, @asottile and @vstinner, I could not cleanly backport this to |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Sorry @asottile and @vstinner, I had trouble checking out the |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@asottile: Automated backport failed. Can you try to backport it manually (use cherry_picker or git cherry-pick -x)? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
…elect module (pythonGH-21066) (cherry picked from commit d051801)
|
GH-21097 is a backport of this pull request to the 3.9 branch. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
GH-21098 is a backport of this pull request to the 3.8 branch. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
…elect module (pythonGH-21066) (cherry picked from commit d051801)
There was an error while loading. Please reload this page.
|
pydoc doesn't show the eventmask parameter whereas it is in select.epoll.register.text_signature. I created bpo-41095: "inspect.signature() doesn't parse text_signature containing a newline character". |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.