GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-41218: Only mark async code with CO_COROUTINE. by Carreau · Pull Request #21357 · python/cpython

Conversation

@Carreau

@Carreau Carreau commented Jul 6, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

3.8.3 had a regression where compiling with
ast.PyCF_ALLOW_TOP_LEVEL_AWAIT would agressively mark things are
coroutine even if there were not.

https://bugs.python.org/issue41218

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jul 6, 2020
@bedevere-bot bedevere-bot added the awaiting review label Jul 6, 2020
pablogsal
pablogsal reviewed Jul 6, 2020
View reviewed changes
Comment thread Python/compile.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
pablogsal
pablogsal reviewed Jul 6, 2020
View reviewed changes
Comment thread Lib/test/test_builtin.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal

pablogsal commented Jul 6, 2020

Copy link
Copy Markdown
Member

@Carreau Could you add also a NEWS entry?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal pablogsal added needs backport to 3.8 labels Jul 6, 2020
@Carreau
bpo-41218: Only mark async code with CO_COROUTINE.
f035498 
3.8.3 had a regression where compiling with
ast.PyCF_ALLOW_TOP_LEVEL_AWAIT woudl agressively mark things are
coroutine even if there were not.
@Carreau
Carreau force-pushed the no-coro branch from b43ca80 to f035498 Compare July 6, 2020 20:42
@Carreau

Carreau commented Jul 6, 2020

Copy link
Copy Markdown
Contributor Author

Rebased, NEWS file added and suggestion applied.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal

pablogsal commented Jul 6, 2020

Copy link
Copy Markdown
Member

Thanks for the quick response @Carreau!

@ambv Could it be possible to include this in 3.8.4?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
pablogsal
pablogsal approved these changes Jul 6, 2020
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Jul 6, 2020
@ambv

ambv commented Jul 6, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Could it be possible to include this in 3.8.4?

How could it not?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ambv
ambv merged commit bd46174 into python:master Jul 6, 2020
@bedevere-bot

bedevere-bot commented Jul 6, 2020

Copy link
Copy Markdown

@ambv: Please replace # with GH- in the commit message next time. Thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Jul 6, 2020

Copy link
Copy Markdown
Contributor

Thanks @Carreau for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Jul 6, 2020
@miss-islington

miss-islington commented Jul 6, 2020

Copy link
Copy Markdown
Contributor

Sorry @Carreau and @ambv, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker bd46174a5a09a54e5ae1077909f923f56a7cf710 3.9
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington miss-islington assigned ambv Jul 6, 2020
@bedevere-bot

bedevere-bot commented Jul 6, 2020

Copy link
Copy Markdown

GH-21361 is a backport of this pull request to the 3.8 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.8 label Jul 6, 2020
@ambv

ambv commented Jul 6, 2020

Copy link
Copy Markdown
Contributor

@pablogsal, approving first, reviewing later is a new style for me ;-)
pablogsal reacted with laugh emoji
All reactions
  • 😄 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 6, 2020
@Carreau @miss-islington
bpo-41218: Only mark async code with CO_COROUTINE. (pythonGH-21357)
7e580e7 
3.8.3 had a regression where compiling with
ast.PyCF_ALLOW_TOP_LEVEL_AWAIT woudl agressively mark things are
coroutine even if there were not.
(cherry picked from commit bd46174)

Co-authored-by: Matthias Bussonnier <[email protected]>
@pablogsal

pablogsal commented Jul 6, 2020

Copy link
Copy Markdown
Member

@pablogsal, approving first, reviewing later is a new style for me ;-)

I forgot to add a couple of suggestions to clean the test suite, I will submit a followup :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
pablogsal pushed a commit to pablogsal/cpython that referenced this pull request Jul 6, 2020
@Carreau @pablogsal
[3.9] bpo-41218: Only mark async code with CO_COROUTINE. (pythonGH-21357
4c6299a 
)

3.8.3 had a regression where compiling with
ast.PyCF_ALLOW_TOP_LEVEL_AWAIT woudl agressively mark things are
coroutine even if there were not.
(cherry picked from commit bd46174)

Co-authored-by: Matthias Bussonnier <[email protected]>
@bedevere-bot

bedevere-bot commented Jul 6, 2020

Copy link
Copy Markdown

GH-21362 is a backport of this pull request to the 3.9 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.9 label Jul 6, 2020
miss-islington added a commit that referenced this pull request Jul 6, 2020
@miss-islington @Carreau
bpo-41218: Only mark async code with CO_COROUTINE. (GH-21357)
41db8ff 
3.8.3 had a regression where compiling with
ast.PyCF_ALLOW_TOP_LEVEL_AWAIT woudl agressively mark things are
coroutine even if there were not.
(cherry picked from commit bd46174)

Co-authored-by: Matthias Bussonnier <[email protected]>
pablogsal added a commit that referenced this pull request Jul 6, 2020
@pablogsal @Carreau
[3.9] bpo-41218: Only mark async code with CO_COROUTINE. (GH-21357) (G…
6488a4a 
…H-21362)

3.8.3 had a regression where compiling with
ast.PyCF_ALLOW_TOP_LEVEL_AWAIT woudl agressively mark things are
coroutine even if there were not.
(cherry picked from commit bd46174)

Co-authored-by: Matthias Bussonnier <[email protected]>

Co-authored-by: Matthias Bussonnier <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@ambv ambv

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@Carreau @pablogsal @ambv @bedevere-bot @miss-islington @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.