GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-1635741: port winapi to multi-stage init by koubaa · Pull Request #21371 · python/cpython

Conversation

@koubaa

@koubaa koubaa commented Jul 7, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

https://bugs.python.org/issue1635741

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jul 7, 2020
@koubaa koubaa changed the title port winapi to multi-stage init bpo-1635741: port winapi to multi-stage init Jul 7, 2020
vstinner
vstinner reviewed Jul 7, 2020
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @corona10 @shihai1991

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Modules/_winapi.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/_winapi.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/_winapi.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/_winapi.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
vstinner
vstinner reviewed Jul 7, 2020
View reviewed changes
Comment thread Modules/_winapi.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
shihai1991
shihai1991 reviewed Jul 8, 2020
View reviewed changes
Comment thread Modules/_winapi.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
vstinner
vstinner reviewed Jul 8, 2020
View reviewed changes
Comment thread Modules/_winapi.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
vstinner
vstinner reviewed Jul 9, 2020
View reviewed changes
Comment thread Modules/_winapi.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/_winapi.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/_winapi.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/_winapi.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
vstinner
vstinner reviewed Jul 9, 2020
View reviewed changes
Comment thread Modules/_winapi.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Jul 9, 2020

Copy link
Copy Markdown
Member

continuous-integration/travis-ci Expected — Waiting for status to be reported
Required

Stupid CI. https://travis-ci.org/github/python/cpython/builds/706422141 ran and completed. But the status was not reported back to GitHub :-(

I restarted the build to try to work around the issue :-/
shihai1991 reacted with laugh emoji
All reactions
  • 😄 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Jul 9, 2020

Copy link
Copy Markdown
Member

I still see " continuous-integration/travis-ci Expected — Waiting for status to be reported ". Hum, I close/reopen the issue to force to re-run all CIs :-(
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner closed this Jul 9, 2020
@vstinner vstinner reopened this Jul 9, 2020
@vstinner

vstinner commented Jul 9, 2020

Copy link
Copy Markdown
Member

Right now, it's still " continuous-integration/travis-ci Expected — Waiting for status to be reported ". Silly CIs :-(
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@koubaa

koubaa commented Aug 9, 2020

Copy link
Copy Markdown
Contributor Author

@vstinner can this be merged?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner
vstinner reviewed Aug 10, 2020
View reviewed changes
Comment thread Modules/_winapi.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Aug 10, 2020

Copy link
Copy Markdown
Member

@corona10 @shihai1991: Would you mind to review this PR?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@shihai1991

shihai1991 commented Aug 10, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Hm, this ci gate skipped again, maybe we can fix it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
shihai1991
shihai1991 approved these changes Aug 10, 2020
View reviewed changes

@shihai1991 shihai1991 left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I have no other comment in here.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added the awaiting core review label Aug 10, 2020
@vstinner

vstinner commented Aug 10, 2020

Copy link
Copy Markdown
Member

Hm, this ci gate skipped again, maybe we can fix it.

See #21806
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@koubaa koubaa closed this Aug 13, 2020
@koubaa koubaa reopened this Aug 13, 2020
koubaa and others added 8 commits August 13, 2020 07:30
@koubaa
port winapi to multi-stage init
67c2350
@koubaa
blurb
12c41c8
@koubaa
reviewer suggestions
f5e2fc2
= @koubaa
fix refcount
283911c
@koubaa
update based on review
e0e1b30
@koubaa
update based on review
7195743
@koubaa
update based on review
a836c71
@koubaa
fix typo
af115c1
@koubaa
check result of Py_BuildValue
42352a4
@koubaa
koubaa force-pushed the bpo-1635741-winapi branch from fce44d9 to 42352a4 Compare August 13, 2020 12:30
@koubaa

koubaa commented Aug 13, 2020

Copy link
Copy Markdown
Contributor Author

I just rebased it to reset the CI
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner merged commit e087f7c into python:master Aug 13, 2020
@bedevere-bot bedevere-bot removed the awaiting core review label Aug 13, 2020
@vstinner

vstinner commented Aug 13, 2020

Copy link
Copy Markdown
Member

Thanks @koubaa, I merged your PR. Thanks @shihai1991 for the review.
shihai1991 reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Aug 20, 2020
@koubaa @shihai1991
bpo-1635741: Port _winapi ext to multi-stage init (pythonGH-21371)
1626edd
@koubaa
koubaa deleted the bpo-1635741-winapi branch August 28, 2020 00:21
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
@koubaa @xzy3-cdc
bpo-1635741: Port _winapi ext to multi-stage init (pythonGH-21371)
b89d2cd
@kylotan kylotan mannequin mentioned this pull request Sep 19, 2022
Py_Finalize() doesn't clear all Python objects at exit #44470
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner left review comments
@shihai1991 shihai1991 shihai1991 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@koubaa @vstinner @shihai1991 @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.