GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-41205: Document Decimal power 0 to the 0 by srinivasreddy · Pull Request #21386 · python/cpython

Conversation

@srinivasreddy

@srinivasreddy srinivasreddy commented Jul 8, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

https://bugs.python.org/issue41205

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@srinivasreddy
bpo-41205: Document Decimal power 0 to the 0
a0e9bf0
@srinivasreddy
srinivasreddy requested review from rhettinger and skrah as code owners July 8, 2020 04:21
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jul 8, 2020
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Jul 8, 2020
mdickinson
mdickinson suggested changes Jul 8, 2020
View reviewed changes

@mdickinson mdickinson left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One nitpicky request to remove the extra blank lines introduced in this PR, and one suggested minor wording change.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Doc/library/decimal.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/library/decimal.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting review label Jul 8, 2020
@bedevere-bot

bedevere-bot commented Jul 8, 2020

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added the awaiting changes label Jul 8, 2020
srinivasreddy and others added 2 commits July 8, 2020 22:07
@srinivasreddy @mdickinson
Update Doc/library/decimal.rst
53898f9 
Co-authored-by: Mark Dickinson <[email protected]>
@srinivasreddy
bpo-41205 rm blank line
7c2cbd0
@srinivasreddy

srinivasreddy commented Jul 8, 2020

Copy link
Copy Markdown
Contributor Author

@mdickinson ✅ . Thanks.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@srinivasreddy
bpo-41205: Rm another line
57e14af
mdickinson
mdickinson approved these changes Jul 8, 2020
View reviewed changes

@mdickinson mdickinson left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates! LGTM. I'll leave this open for a bit in case @skrah or @rhettinger wants to comment.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting changes labels Jul 8, 2020
skrah
skrah approved these changes Jul 8, 2020
View reviewed changes
@skrah

skrah commented Jul 8, 2020

Copy link
Copy Markdown
Contributor

Looks good, thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mdickinson mdickinson added needs backport to 3.8 labels Jul 9, 2020
rhettinger
rhettinger requested changes Jul 12, 2020
View reviewed changes
Comment thread Doc/library/decimal.rst Outdated
the result is finite and can be expressed exactly in 'precision' digits.
The rounding mode of the context is used. Results are always correctly-rounded
in the Python version.
in the Python version. ``Decimal(0) ** Decimal(0)`` results in

@rhettinger rhettinger Jul 12, 2020

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a blank line so this gets its own paragraph.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting changes and removed awaiting merge labels Jul 12, 2020
@bedevere-bot

bedevere-bot commented Jul 12, 2020

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@srinivasreddy
bpo-41205: Add extra line
4489ce5
@srinivasreddy

srinivasreddy commented Jul 13, 2020

Copy link
Copy Markdown
Contributor Author

@rhettinger Done Raymond. Thanks!!!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@skrah

skrah commented Jul 19, 2020

Copy link
Copy Markdown
Contributor

@rhettinger's comment has been addressed, so I think we can merge.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Jul 19, 2020

Copy link
Copy Markdown
Contributor

Thanks @srinivasreddy for the PR, and @skrah for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting changes label Jul 19, 2020
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 19, 2020
@srinivasreddy @miss-islington
bpo-41205: Document Decimal power 0 to the 0 (pythonGH-21386)
c2564a5 
Co-authored-by: Mark Dickinson <[email protected]>
(cherry picked from commit 10e4664)

Co-authored-by: Srinivas Reddy Thatiparthy (శ్రీనివాస్  రెడ్డి తాటిపర్తి) <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.9 label Jul 19, 2020
@bedevere-bot

bedevere-bot commented Jul 19, 2020

Copy link
Copy Markdown

GH-21547 is a backport of this pull request to the 3.9 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.8 label Jul 19, 2020
@bedevere-bot

bedevere-bot commented Jul 19, 2020

Copy link
Copy Markdown

GH-21548 is a backport of this pull request to the 3.8 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 19, 2020
@srinivasreddy @miss-islington
bpo-41205: Document Decimal power 0 to the 0 (pythonGH-21386)
cf9dc74 
Co-authored-by: Mark Dickinson <[email protected]>
(cherry picked from commit 10e4664)

Co-authored-by: Srinivas Reddy Thatiparthy (శ్రీనివాస్  రెడ్డి తాటిపర్తి) <[email protected]>
miss-islington added a commit that referenced this pull request Jul 19, 2020
@miss-islington @srinivasreddy
bpo-41205: Document Decimal power 0 to the 0 (GH-21386)
8831162 
Co-authored-by: Mark Dickinson <[email protected]>
(cherry picked from commit 10e4664)

Co-authored-by: Srinivas Reddy Thatiparthy (శ్రీనివాస్  రెడ్డి తాటిపర్తి) <[email protected]>
miss-islington added a commit that referenced this pull request Jul 19, 2020
@miss-islington @srinivasreddy
bpo-41205: Document Decimal power 0 to the 0 (GH-21386)
dac8a3a 
Co-authored-by: Mark Dickinson <[email protected]>
(cherry picked from commit 10e4664)

Co-authored-by: Srinivas Reddy Thatiparthy (శ్రీనివాస్  రెడ్డి తాటిపర్తి) <[email protected]>
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Aug 4, 2020
@srinivasreddy @mdickinson @shihai1991
bpo-41205: Document Decimal power 0 to the 0 (pythonGH-21386)
de846a1 
Co-authored-by: Mark Dickinson <[email protected]>
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Aug 20, 2020
@srinivasreddy @mdickinson @shihai1991
bpo-41205: Document Decimal power 0 to the 0 (pythonGH-21386)
64d261a 
Co-authored-by: Mark Dickinson <[email protected]>
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
@srinivasreddy @mdickinson @xzy3-cdc
bpo-41205: Document Decimal power 0 to the 0 (pythonGH-21386)
31ecf5a 
Co-authored-by: Mark Dickinson <[email protected]>
@JD-Veiga JD-Veiga mannequin mentioned this pull request May 10, 2023
Documentation Decimal power 0 to the 0 is Nan (versus 0 to the 0 which is 1) #85377
Closed
@jstasiak jstasiak mentioned this pull request May 30, 2024
ipaddress: Shared Address Space (100.64.0.0/10) is neither private nor global #119812
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhettinger rhettinger Awaiting requested review from rhettinger
2 more reviewers
@mdickinson mdickinson mdickinson approved these changes
@skrah skrah skrah approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@srinivasreddy @bedevere-bot @skrah @miss-islington @mdickinson @rhettinger @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.