GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Revert "bpo-40170: PyType_HasFeature() now always calls PyType_GetFlags() (GH-19378)" by vstinner · Pull Request #21390 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Jul 8, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This partially reverts commit 45ec5b9.

https://bugs.python.org/issue40170

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
Revert "bpo-40170: PyType_HasFeature() now always calls PyType_GetFla…
4975a9e 
…gs() (GH-19378)"

This partially reverts commit 45ec5b9.
@vstinner vstinner added the needs backport to 3.9 label Jul 8, 2020
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jul 8, 2020
@bedevere-bot bedevere-bot added the awaiting core review label Jul 8, 2020
@vstinner
vstinner merged commit b26a0db into python:master Jul 8, 2020
@miss-islington

miss-islington commented Jul 8, 2020

Copy link
Copy Markdown
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting core review label Jul 8, 2020
@vstinner
vstinner deleted the revert_type_has_feature branch July 8, 2020 09:02
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 8, 2020
@vstinner @miss-islington
Revert "bpo-40170: PyType_HasFeature() now always calls PyType_GetFla…
30fd8fc 
…gs() (pythonGH-19378)" (pythonGH-21390)

This partially reverts commit 45ec5b9.
(cherry picked from commit b26a0db)

Co-authored-by: Victor Stinner <[email protected]>
@bedevere-bot

bedevere-bot commented Jul 8, 2020

Copy link
Copy Markdown

GH-21391 is a backport of this pull request to the 3.9 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.9 label Jul 8, 2020
miss-islington added a commit that referenced this pull request Jul 8, 2020
@miss-islington @vstinner
Revert "bpo-40170: PyType_HasFeature() now always calls PyType_GetFla…
a0a6f11 
…gs() (GH-19378)" (GH-21390)

This partially reverts commit 45ec5b9.
(cherry picked from commit b26a0db)

Co-authored-by: Victor Stinner <[email protected]>
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jul 12, 2020
@vstinner @shihai1991
Revert "bpo-40170: PyType_HasFeature() now always calls PyType_GetFla…
cb4bfdc 
…gs() (pythonGH-19378)" (pythonGH-21390)

This partially reverts commit 45ec5b9.
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Aug 20, 2020
@vstinner @shihai1991
Revert "bpo-40170: PyType_HasFeature() now always calls PyType_GetFla…
e4512c0 
…gs() (pythonGH-19378)" (pythonGH-21390)

This partially reverts commit 45ec5b9.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@vstinner @miss-islington @bedevere-bot @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.