GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-36346: Make using the legacy Unicode C API optional by serhiy-storchaka · Pull Request #21437 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Jul 10, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Do not use the legacy Unicode C API which depends on the wchar_t* cache if USE_UNICODE_WCHAR_CACHE is defined as false.

It can help to test in advance the effect of removing the wchar_t* cache.

https://bugs.python.org/issue36346

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
serhiy-storchaka added 30 commits March 18, 2019 16:23
@serhiy-storchaka
bpo-36346: Prepare for removing the legacy Unicode C API.
699e616
Add two compile time options: HAVE_UNICODE_WCHAR_CACHE and
USE_UNICODE_WCHAR_CACHE.

USE_UNICODE_WCHAR_CACHE makes the interpreter not using the
wchar_t cache and the legacy Unicode C API.

HAVE_UNICODE_WCHAR_CACHE removes the wchar_t cache and the
legacy Unicode C API that depends on it.
@serhiy-storchaka
Fix winreg.SetValue().
60b89c9
@serhiy-storchaka
Clean up some ifdefs in _testcapimodule.
f386b63
@serhiy-storchaka
Make path_cleanup() paranoidally safer.
11e0e0c
@serhiy-storchaka
Merge branch 'master' into disable-wchar-cache
236f608
@serhiy-storchaka
Fix os.scandir().
8750d48
@serhiy-storchaka
Merge branch 'master' into disable-wchar-cache
431e71f
@serhiy-storchaka
Merge branch 'master' into disable-wchar-cache
545c7a9
@serhiy-storchaka
Merge branch 'master' into disable-wchar-cache
3c1ab31
@serhiy-storchaka
Merge branch 'master' into disable-wchar-cache
54b0561
@serhiy-storchaka
Merge branch 'master' into disable-wchar-cache
2c62d96
@serhiy-storchaka
Merge branch 'master' into disable-wchar-cache
6d89775
@serhiy-storchaka
Silence compiler warnings.
3b5294a
@serhiy-storchaka
Fix PyUnicode_IsIdentifier for the cache-less build.
e7898fa
@serhiy-storchaka
Silence compiler warnings on Windows.
fd641c6
@serhiy-storchaka
Merge branch 'master' into disable-wchar-cache
a79d935
@serhiy-storchaka
Fix compiler warning in _testcapi.
ed14aa9
@serhiy-storchaka
Merge branch 'master' into disable-wchar-cache
c5eb102
@serhiy-storchaka
Merge branch 'master' into disable-wchar-cache
d529224
@serhiy-storchaka
Merge branch 'master' into disable-wchar-cache
6102b4b
@serhiy-storchaka
Merge branch 'master' into disable-wchar-cache
74695b3
@serhiy-storchaka
Use HAVE_UNICODE_WCHAR_CACHE instead of USE_UNICODE_WCHAR_CACHE in _P…
97b5228
…y_DumpASCII().
@serhiy-storchaka
Set HAVE_UNICODE_WCHAR_CACHE and USE_UNICODE_WCHAR_CACHE only if they…
d6ba6b7
… were not set.
@serhiy-storchaka
Remove Py_UNICODE_MATCH.
0da4146
@serhiy-storchaka
Merge branch 'master' into disable-wchar-cache
51365fb
@serhiy-storchaka
Fix unterminated #if.
e425908
@serhiy-storchaka
Reset arraymodule.c.
8a9259b
@serhiy-storchaka
Merge branch 'master' into disable-wchar-cache
76ba4b6
@serhiy-storchaka
Temporary disable the wchar_t cache by default.
16ac7fd
@serhiy-storchaka
Remove HAVE_UNICODE_WCHAR_CACHE.
5950b5c
@serhiy-storchaka
serhiy-storchaka requested review from a team, rhettinger and skrah as code owners July 10, 2020 15:47
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jul 10, 2020
@bedevere-bot bedevere-bot added the awaiting core review label Jul 10, 2020
@serhiy-storchaka serhiy-storchaka added the skip news label Jul 10, 2020
serhiy-storchaka added 2 commits July 10, 2020 20:47
@serhiy-storchaka
Merge branch 'master' into do-not-use-wchar-cache
065fc2d
@serhiy-storchaka
Fix possible leaks.
672b8d7
@serhiy-storchaka
serhiy-storchaka merged commit 4c8f09d into python:master Jul 10, 2020
@bedevere-bot bedevere-bot removed the awaiting core review label Jul 10, 2020
@serhiy-storchaka
serhiy-storchaka deleted the do-not-use-wchar-cache branch July 10, 2020 20:26
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Aug 20, 2020
@serhiy-storchaka @shihai1991
bpo-36346: Make using the legacy Unicode C API optional (pythonGH-21437)
11ce089
Add compile time option USE_UNICODE_WCHAR_CACHE. Setting it to 0
makes the interpreter not using the wchar_t cache and the legacy Unicode C API.
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
@serhiy-storchaka @xzy3-cdc
bpo-36346: Make using the legacy Unicode C API optional (pythonGH-21437)
14ade10
Add compile time option USE_UNICODE_WCHAR_CACHE. Setting it to 0
makes the interpreter not using the wchar_t cache and the legacy Unicode C API.
@bedevere-bot bedevere-bot mentioned this pull request Apr 10, 2022
Prepare for removing the legacy Unicode C API #80527
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhettinger rhettinger Awaiting requested review from rhettinger
@skrah skrah Awaiting requested review from skrah

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@serhiy-storchaka @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.