GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-85525: Indicate supported sound header formats by nanjekyejoannah · Pull Request #21575 · python/cpython

Conversation

@nanjekyejoannah

@nanjekyejoannah nanjekyejoannah commented Jul 21, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

#85525

https://bugs.python.org/issue41353

  • Issue: Indicate supported sound header formats #85525

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nanjekyejoannah
Indicate supported sound header formats
c522486
@nanjekyejoannah nanjekyejoannah added the skip news label Jul 21, 2020
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jul 21, 2020
@bedevere-bot bedevere-bot added the awaiting core review label Jul 21, 2020
merwok
merwok reviewed Jul 24, 2020
View reviewed changes
Comment thread Doc/library/sndhdr.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/library/sndhdr.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@nanjekyejoannah nanjekyejoannah mentioned this pull request Apr 11, 2022
Indicate supported sound header formats #85525
Closed
@hugovk

hugovk commented Apr 11, 2022

Copy link
Copy Markdown
Member

Note the sndhdr module is deprecated in 3.11 and set for removal in 3.13.

See PEP 594 – Removing dead batteries from the standard library and #91217.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood

AlexWaygood commented Apr 12, 2022

Copy link
Copy Markdown
Member

Note the sndhdr module is deprecated in 3.11 and set for removal in 3.13.

See PEP 594 – Removing dead batteries from the standard library and #91217.

Nonetheless, this does look like a relatively simple docs enhancement that would be quite nice to have. It would be nice if it could get over the line.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra
Merge branch 'main' into sndhdr
bf47b19
@JelleZijlstra
JelleZijlstra self-requested a review April 12, 2022 13:49
@JelleZijlstra JelleZijlstra changed the title bpo-41353: Indicate supported sound header formats gh-85525: Indicate supported sound header formats Apr 12, 2022
@JelleZijlstra
JelleZijlstra removed their request for review April 13, 2022 02:56
@nanjekyejoannah

nanjekyejoannah commented Apr 13, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

@willingc can you help review this and see if it can be merged?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
hugovk
hugovk reviewed Apr 13, 2022
View reviewed changes
Comment thread Doc/library/sndhdr.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/library/sndhdr.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@AA-Turner AA-Turner added needs backport to 3.10 needs backport to 3.11 only security fixes docs Documentation in the Doc dir and removed CLA signed labels Jun 7, 2022
@AA-Turner

AA-Turner commented Jun 7, 2022

Copy link
Copy Markdown
Member

I agree with @AlexWaygood that this would be useful to consumers of the module for 3.10 through 3.12 -- I've no comments beyond Hugo's points though.

A
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions

github-actions Bot commented Jul 30, 2022

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Jul 30, 2022
nanjekyejoannah and others added 2 commits October 15, 2022 08:29
@nanjekyejoannah
modify file names
7514e4f
@nanjekyejoannah
Merge branch 'main' into sndhdr
9659123
@nanjekyejoannah
nanjekyejoannah merged commit 05c042e into python:main Oct 15, 2022
@bedevere-bot bedevere-bot removed the awaiting core review label Oct 15, 2022
@miss-islington

miss-islington commented Oct 15, 2022

Copy link
Copy Markdown
Contributor

Thanks @nanjekyejoannah for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Oct 15, 2022

Copy link
Copy Markdown
Contributor

Sorry @nanjekyejoannah, I had trouble checking out the 3.11 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 05c042e70786bd2e3fcb274d185e1e0a54dab5a7 3.11
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington miss-islington assigned nanjekyejoannah Oct 15, 2022
@miss-islington

miss-islington commented Oct 15, 2022

Copy link
Copy Markdown
Contributor

Sorry, @nanjekyejoannah, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 05c042e70786bd2e3fcb274d185e1e0a54dab5a7 3.10
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood AlexWaygood removed the needs backport to 3.11 only security fixes label Oct 15, 2022
@AlexWaygood AlexWaygood added the needs backport to 3.11 only security fixes label Oct 15, 2022
@miss-islington

miss-islington commented Oct 15, 2022

Copy link
Copy Markdown
Contributor

Thanks @nanjekyejoannah for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Oct 15, 2022

Copy link
Copy Markdown
Contributor

Sorry @nanjekyejoannah, I had trouble checking out the 3.11 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 05c042e70786bd2e3fcb274d185e1e0a54dab5a7 3.11
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood AlexWaygood added needs backport to 3.11 only security fixes and removed needs backport to 3.11 only security fixes labels Oct 15, 2022
@miss-islington

miss-islington commented Oct 15, 2022

Copy link
Copy Markdown
Contributor

Thanks @nanjekyejoannah for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 15, 2022
@nanjekyejoannah @miss-islington
pythongh-85525: Indicate supported sound header formats (pythonGH-21575)
26f058c 
* Indicate supported sound header formats

* modify file names

Co-authored-by: Jelle Zijlstra <[email protected]>
(cherry picked from commit 05c042e)

Co-authored-by: Joannah Nanjekye <[email protected]>
@bedevere-bot

bedevere-bot commented Oct 15, 2022

Copy link
Copy Markdown

GH-98277 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Oct 15, 2022
miss-islington added a commit that referenced this pull request Oct 15, 2022
@miss-islington @nanjekyejoannah
gh-85525: Indicate supported sound header formats (GH-21575)
232a988 
* Indicate supported sound header formats

* modify file names

Co-authored-by: Jelle Zijlstra <[email protected]>
(cherry picked from commit 05c042e)

Co-authored-by: Joannah Nanjekye <[email protected]>
merwok
merwok reviewed Oct 15, 2022
View reviewed changes
Comment thread Doc/library/sndhdr.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@ZeroIntensity ZeroIntensity removed the needs backport to 3.10 label Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@merwok merwok merwok left review comments
@hugovk hugovk hugovk left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@nanjekyejoannah nanjekyejoannah

Labels

docs Documentation in the Doc dir skip news stale Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

10 participants

@nanjekyejoannah @hugovk @AlexWaygood @AA-Turner @miss-islington @bedevere-bot @merwok @the-knights-who-say-ni @ZeroIntensity @JelleZijlstra
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.