GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-41364: Reduce import overhead of uuid module by zooba · Pull Request #21586 · python/cpython

Conversation

@zooba

@zooba zooba commented Jul 21, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

https://bugs.python.org/issue41364

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@zooba
bpo-41364: Reduce import overhead of uuid module
d58d6f0
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jul 21, 2020
@bedevere-bot bedevere-bot added the awaiting core review label Jul 21, 2020
@zooba zooba added needs backport to 3.8 performance Performance or resource usage and removed CLA signed awaiting core review labels Jul 21, 2020
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jul 21, 2020
@zooba
Lazily import platform
59bc5d5
@zooba
zooba merged commit bf2f76e into python:master Jul 21, 2020
@miss-islington

miss-islington commented Jul 21, 2020

Copy link
Copy Markdown
Contributor

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 21, 2020
@zooba @miss-islington
bpo-41364: Reduce import overhead of uuid module (pythonGH-21586)
2105af8 
(cherry picked from commit bf2f76e)

Co-authored-by: Steve Dower <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.9 label Jul 21, 2020
@bedevere-bot

bedevere-bot commented Jul 21, 2020

Copy link
Copy Markdown

GH-21589 is a backport of this pull request to the 3.9 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Jul 21, 2020

Copy link
Copy Markdown
Contributor

Sorry, @zooba, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker bf2f76ec0976c09de79c8827764f30e3b6fba776 3.8
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington miss-islington assigned zooba Jul 21, 2020
@zooba
zooba deleted the bpo-41364 branch July 22, 2020 00:09
miss-islington added a commit that referenced this pull request Jul 22, 2020
@miss-islington @zooba
bpo-41364: Reduce import overhead of uuid module (GH-21586)
00466db 
(cherry picked from commit bf2f76e)

Co-authored-by: Steve Dower <[email protected]>
zooba added a commit to zooba/cpython that referenced this pull request Jul 22, 2020
@zooba
bpo-41364: Reduce import overhead of uuid module (pythonGH-21586)
6e1d1c4
@bedevere-bot bedevere-bot removed the needs backport to 3.8 label Jul 22, 2020
@bedevere-bot

bedevere-bot commented Jul 22, 2020

Copy link
Copy Markdown

GH-21591 is a backport of this pull request to the 3.8 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
zooba added a commit that referenced this pull request Jul 22, 2020
@zooba
bpo-41364: Reduce import overhead of uuid module (GH-21586)
a18f22a
@bedevere-bot

bedevere-bot commented Jul 22, 2020

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Windows7 SP1 3.8 has failed when building commit a18f22a.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/163/builds/398) and take a look at the build logs.
  4. Check if the failure is related to this commit (a18f22a) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/163/builds/398

Summary of the results of the build (if available):

Click to see traceback logs 
remote: Enumerating objects: 1        
remote: Enumerating objects: 9, done.        
remote: Counting objects:  11% (1/9)        
remote: Counting objects:  22% (2/9)        
remote: Counting objects:  33% (3/9)        
remote: Counting objects:  44% (4/9)        
remote: Counting objects:  55% (5/9)        
remote: Counting objects:  66% (6/9)        
remote: Counting objects:  77% (7/9)        
remote: Counting objects:  88% (8/9)        
remote: Counting objects: 100% (9/9)        
remote: Counting objects: 100% (9/9), done.        
remote: Compressing objects:  50% (1/2)        
remote: Compressing objects: 100% (2/2)        
remote: Compressing objects: 100% (2/2), done.        
remote: Total 9 (delta 6), reused 8 (delta 6), pack-reused 0        
From https://github.com/python/cpython
 * branch            3.8        -> FETCH_HEAD
Reset branch '3.8'

Could Not Find C:\buildbot.python.org\3.8.kloth-win64\build\Lib\*.pyc
The system cannot find the file specified.
Could Not Find C:\buildbot.python.org\3.8.kloth-win64\build\PCbuild\python*.zip

Could Not Find C:\buildbot.python.org\3.8.kloth-win64\build\Lib\*.pyc
The system cannot find the file specified.
Could Not Find C:\buildbot.python.org\3.8.kloth-win64\build\PCbuild\python*.zip
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Aug 4, 2020
@zooba @shihai1991
bpo-41364: Reduce import overhead of uuid module (pythonGH-21586)
808203d
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Aug 20, 2020
@zooba @shihai1991
bpo-41364: Reduce import overhead of uuid module (pythonGH-21586)
59b14fb
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
@zooba @xzy3-cdc
bpo-41364: Reduce import overhead of uuid module (pythonGH-21586)
820835c
hauntsaninja added a commit to hauntsaninja/cpython that referenced this pull request Feb 8, 2024
@hauntsaninja
Reduce import overhead of uuid module
3ecc291 
This follows in the footsteps of python#21586
hauntsaninja added a commit to hauntsaninja/cpython that referenced this pull request Feb 8, 2024
@hauntsaninja
Reduce import overhead of uuid module
ed29bd6 
This follows in the footsteps of python#21586
This speeds up import uuid by about 6ms on Linux.

Before:
```
λ hyperfine -w 4 "./python -c 'import uuid'"
Benchmark 1: ./python -c 'import uuid'
  Time (mean ± σ):      20.4 ms ±   0.4 ms    [User: 16.7 ms, System: 3.8 ms]
  Range (min … max):    19.6 ms …  21.8 ms    136 runs
```
After:
```
λ hyperfine -w 4 "./python -c 'import uuid'"
Benchmark 1: ./python -c 'import uuid'
  Time (mean ± σ):      14.5 ms ±   0.3 ms    [User: 11.5 ms, System: 3.2 ms]
  Range (min … max):    13.9 ms …  16.0 ms    175 runs
```
@hauntsaninja hauntsaninja mentioned this pull request Feb 8, 2024
gh-109653: Reduce import overhead of uuid module on Linux #115160
Merged
hauntsaninja added a commit that referenced this pull request Mar 6, 2024
@hauntsaninja
gh-109653: Reduce import overhead of uuid module on Linux (#115160)
68b8fff 
This follows in the footsteps of #21586
This speeds up import uuid by about 6ms on Linux.

Before:
```
λ hyperfine -w 4 "./python -c 'import uuid'"
Benchmark 1: ./python -c 'import uuid'
  Time (mean ± σ):      20.4 ms ±   0.4 ms    [User: 16.7 ms, System: 3.8 ms]
  Range (min … max):    19.6 ms …  21.8 ms    136 runs
```
After:
```
λ hyperfine -w 4 "./python -c 'import uuid'"
Benchmark 1: ./python -c 'import uuid'
  Time (mean ± σ):      14.5 ms ±   0.3 ms    [User: 11.5 ms, System: 3.2 ms]
  Range (min … max):    13.9 ms …  16.0 ms    175 runs
```
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
@hauntsaninja @adorilson
pythongh-109653: Reduce import overhead of uuid module on Linux (pyth…
d4fa77a 
…on#115160)

This follows in the footsteps of python#21586
This speeds up import uuid by about 6ms on Linux.

Before:
```
λ hyperfine -w 4 "./python -c 'import uuid'"
Benchmark 1: ./python -c 'import uuid'
  Time (mean ± σ):      20.4 ms ±   0.4 ms    [User: 16.7 ms, System: 3.8 ms]
  Range (min … max):    19.6 ms …  21.8 ms    136 runs
```
After:
```
λ hyperfine -w 4 "./python -c 'import uuid'"
Benchmark 1: ./python -c 'import uuid'
  Time (mean ± σ):      14.5 ms ±   0.3 ms    [User: 11.5 ms, System: 3.2 ms]
  Range (min … max):    13.9 ms …  16.0 ms    175 runs
```
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@hauntsaninja @diegorusso
pythongh-109653: Reduce import overhead of uuid module on Linux (pyth…
965c421 
…on#115160)

This follows in the footsteps of python#21586
This speeds up import uuid by about 6ms on Linux.

Before:
```
λ hyperfine -w 4 "./python -c 'import uuid'"
Benchmark 1: ./python -c 'import uuid'
  Time (mean ± σ):      20.4 ms ±   0.4 ms    [User: 16.7 ms, System: 3.8 ms]
  Range (min … max):    19.6 ms …  21.8 ms    136 runs
```
After:
```
λ hyperfine -w 4 "./python -c 'import uuid'"
Benchmark 1: ./python -c 'import uuid'
  Time (mean ± σ):      14.5 ms ±   0.3 ms    [User: 11.5 ms, System: 3.2 ms]
  Range (min … max):    13.9 ms …  16.0 ms    175 runs
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@zooba zooba

Labels

performance Performance or resource usage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@zooba @miss-islington @bedevere-bot @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.