GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-41306: Allow scale value to not be rounded by E-Paine · Pull Request #21715 · python/cpython

Conversation

@E-Paine

@E-Paine E-Paine commented Aug 3, 2020 •
edited by miss-islington
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This fixes the test failure with Tk 6.8.10 which is caused by changes to how Tk rounds the from, to and tickinterval arguments. This PR uses noconv if the patchlevel is greater than or equal to 8.6.10 (credit to Serhiy for this idea as it is much simpler than what I previously proposed).

Going into more detail for those who want it, the Tk change was made in commit 591f68c and means that the arguments listed above are rounded relative to the value of from. However, when rounding the from argument (line 623), it is rounded relative to itself (i.e. rounding 0) and therefore the assigned value for from is always what is given (no matter what values of from and resolution).

https://bugs.python.org/issue41306

Automerge-Triggered-By: @pablogsal

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@E-Paine
Allow scale value to not be rounded
1c8759c
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Aug 3, 2020
@bedevere-bot bedevere-bot added the awaiting review label Aug 3, 2020
serhiy-storchaka
serhiy-storchaka reviewed Aug 3, 2020
View reviewed changes
Comment thread Lib/tkinter/test/test_tkinter/test_widgets.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

@E-Paine
Reverted 'allow_not_rounded' changes and action Serhiy's recommendation
fc07de8
@E-Paine
E-Paine force-pushed the test_from branch from c29f8f6 to fc07de8 Compare August 3, 2020 13:42
blurb-it Bot and others added 2 commits August 3, 2020 13:44
@blurb-it
📜🤖 Added by blurb_it.
e184ad8
@E-Paine
Put "conv" kwarg on new line
bdd3cb5
@E-Paine

E-Paine commented Aug 16, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

I recently got an update on the Tk issue I created which, in short, says this change is not a bug and is here to stay (hence < is correct rather than !=). @serhiy-storchaka, would you mind please re-reviewing this PR (you may wish to credit yourself in the news as the code changes are pretty much just your's now :-).

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@E-Paine
Merge 'master' into test_from
a8ac6bd
@terryjreedy terryjreedy mentioned this pull request Sep 25, 2020
bpo-39107: Updated Tcl and Tk to 8.6.10 in Windows installer #22405
Merged
terryjreedy
terryjreedy reviewed Sep 25, 2020
View reviewed changes
Comment thread Lib/tkinter/test/test_tkinter/test_widgets.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

@E-Paine @terryjreedy
Use @terryjreedy's conv kwarg suggestion
8b8060e
Co-authored-by: Terry Jan Reedy <[email protected]>
@pablogsal pablogsal self-assigned this Oct 8, 2020
pablogsal
pablogsal reviewed Oct 8, 2020
View reviewed changes
Comment thread Misc/NEWS.d/next/Tests/2020-08-03-13-44-37.bpo-41306.VDoWXI.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

@pablogsal
Update Misc/NEWS.d/next/Tests/2020-08-03-13-44-37.bpo-41306.VDoWXI.rst
3f9147a
pablogsal
pablogsal approved these changes Oct 8, 2020
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Oct 8, 2020
@pablogsal pablogsal added needs backport to 3.8 labels Oct 8, 2020
pablogsal
pablogsal reviewed Oct 8, 2020
View reviewed changes
Comment thread Lib/tkinter/test/test_tkinter/test_widgets.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

pablogsal
pablogsal reviewed Oct 8, 2020
View reviewed changes
Comment thread Lib/tkinter/test/test_tkinter/test_widgets.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

@pablogsal
Update Lib/tkinter/test/test_tkinter/test_widgets.py
42ec16e
@miss-islington

miss-islington commented Oct 8, 2020

Copy link
Copy Markdown
Contributor

@E-Paine: Status check is done, and it's a success ✅ .

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

1 similar comment
@miss-islington

miss-islington commented Oct 8, 2020

Copy link
Copy Markdown
Contributor

@E-Paine: Status check is done, and it's a success ✅ .

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@miss-islington

miss-islington commented Oct 8, 2020

Copy link
Copy Markdown
Contributor

Sorry, I can't merge this PR. Reason: 2 of 4 required status checks have not succeeded: 1 expected..

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

1 similar comment
@miss-islington

miss-islington commented Oct 8, 2020

Copy link
Copy Markdown
Contributor

Sorry, I can't merge this PR. Reason: 2 of 4 required status checks have not succeeded: 1 expected..

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

pablogsal
pablogsal reviewed Oct 8, 2020
View reviewed changes
Comment thread Lib/tkinter/test/test_tkinter/test_widgets.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

@E-Paine

E-Paine commented Oct 8, 2020

Copy link
Copy Markdown
Contributor Author

Probably dumb question: what's the status check (what is it checking for - is there something wrong with the PR)?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@miss-islington

miss-islington commented Oct 8, 2020

Copy link
Copy Markdown
Contributor

@E-Paine: Status check is done, and it's a success ✅ .

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@miss-islington
miss-islington merged commit aecf036 into python:master Oct 8, 2020
@miss-islington

miss-islington commented Oct 8, 2020

Copy link
Copy Markdown
Contributor

Thanks @E-Paine for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the awaiting merge label Oct 8, 2020
@miss-islington

miss-islington commented Oct 8, 2020

Copy link
Copy Markdown
Contributor

Sorry @E-Paine, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker aecf036738a404371303e770f4ce4fd9f7d43de7 3.9

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@miss-islington miss-islington assigned miss-islington and unassigned pablogsal Oct 8, 2020
@bedevere-bot bedevere-bot removed the needs backport to 3.8 label Oct 8, 2020
@bedevere-bot

bedevere-bot commented Oct 8, 2020

Copy link
Copy Markdown

GH-22596 is a backport of this pull request to the 3.8 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 8, 2020
@E-Paine @miss-islington
bpo-41306: Allow scale value to not be rounded (pythonGH-21715)
006ddb8
This fixes the test failure with Tk 6.8.10 which is caused by changes to how Tk rounds the `from`, `to` and `tickinterval` arguments. This PR uses `noconv` if the patchlevel is greater than or equal to 8.6.10 (credit to Serhiy for this idea as it is much simpler than what I previously proposed).

Going into more detail for those who want it, the Tk change was made in [commit 591f68c](tcltk/tk@591f68c) and means that the arguments listed above are rounded relative to the value of `from`. However, when rounding the `from` argument ([line 623](https://github.com/tcltk/tk/blob/591f68cb382525b72664c6fecaab87742b6cc87a/generic/tkScale.cGH-L623)), it is rounded relative to itself (i.e. rounding `0`) and therefore the assigned value for `from` is always what is given (no matter what values of `from` and `resolution`).

Automerge-Triggered-By: @pablogsal
(cherry picked from commit aecf036)

Co-authored-by: E-Paine <[email protected]>
@E-Paine

E-Paine commented Oct 8, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

Am I able do the cherry pick because I don't have repo write permissions?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@pablogsal pablogsal removed the needs backport to 3.9 label Oct 8, 2020
miss-islington added a commit that referenced this pull request Oct 8, 2020
@miss-islington @E-Paine
bpo-41306: Allow scale value to not be rounded (GH-21715)
3d103e0
This fixes the test failure with Tk 6.8.10 which is caused by changes to how Tk rounds the `from`, `to` and `tickinterval` arguments. This PR uses `noconv` if the patchlevel is greater than or equal to 8.6.10 (credit to Serhiy for this idea as it is much simpler than what I previously proposed).

Going into more detail for those who want it, the Tk change was made in [commit 591f68c](tcltk/tk@591f68c) and means that the arguments listed above are rounded relative to the value of `from`. However, when rounding the `from` argument ([line 623](https://github.com/tcltk/tk/blob/591f68cb382525b72664c6fecaab87742b6cc87a/generic/tkScale.cGH-L623)), it is rounded relative to itself (i.e. rounding `0`) and therefore the assigned value for `from` is always what is given (no matter what values of `from` and `resolution`).

Automerge-Triggered-By: @pablogsal
(cherry picked from commit aecf036)

Co-authored-by: E-Paine <[email protected]>
@pablogsal pablogsal added the needs backport to 3.9 label Oct 8, 2020
@miss-islington

miss-islington commented Oct 8, 2020

Copy link
Copy Markdown
Contributor

Thanks @E-Paine for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 8, 2020
@E-Paine @miss-islington
bpo-41306: Allow scale value to not be rounded (pythonGH-21715)
76377bb
This fixes the test failure with Tk 6.8.10 which is caused by changes to how Tk rounds the `from`, `to` and `tickinterval` arguments. This PR uses `noconv` if the patchlevel is greater than or equal to 8.6.10 (credit to Serhiy for this idea as it is much simpler than what I previously proposed).

Going into more detail for those who want it, the Tk change was made in [commit 591f68c](tcltk/tk@591f68c) and means that the arguments listed above are rounded relative to the value of `from`. However, when rounding the `from` argument ([line 623](https://github.com/tcltk/tk/blob/591f68cb382525b72664c6fecaab87742b6cc87a/generic/tkScale.cGH-L623)), it is rounded relative to itself (i.e. rounding `0`) and therefore the assigned value for `from` is always what is given (no matter what values of `from` and `resolution`).

Automerge-Triggered-By: @pablogsal
(cherry picked from commit aecf036)

Co-authored-by: E-Paine <[email protected]>
@bedevere-bot

bedevere-bot commented Oct 8, 2020

Copy link
Copy Markdown

GH-22597 is a backport of this pull request to the 3.9 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 label Oct 8, 2020
@E-Paine
E-Paine deleted the test_from branch October 8, 2020 16:20
miss-islington added a commit that referenced this pull request Oct 8, 2020
@miss-islington @E-Paine
bpo-41306: Allow scale value to not be rounded (GH-21715)
15e091f
This fixes the test failure with Tk 6.8.10 which is caused by changes to how Tk rounds the `from`, `to` and `tickinterval` arguments. This PR uses `noconv` if the patchlevel is greater than or equal to 8.6.10 (credit to Serhiy for this idea as it is much simpler than what I previously proposed).

Going into more detail for those who want it, the Tk change was made in [commit 591f68c](tcltk/tk@591f68c) and means that the arguments listed above are rounded relative to the value of `from`. However, when rounding the `from` argument ([line 623](https://github.com/tcltk/tk/blob/591f68cb382525b72664c6fecaab87742b6cc87a/generic/tkScale.cGH-L623)), it is rounded relative to itself (i.e. rounding `0`) and therefore the assigned value for `from` is always what is given (no matter what values of `from` and `resolution`).

Automerge-Triggered-By: @pablogsal
(cherry picked from commit aecf036)

Co-authored-by: E-Paine <[email protected]>
@E-Paine

E-Paine commented Oct 8, 2020

Copy link
Copy Markdown
Contributor Author

@pablogsal thanks!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

shihai1991 added a commit to shihai1991/cpython that referenced this pull request Oct 9, 2020
@shihai1991
Merge remote-tracking branch 'origin/master' into bpo_39337_new_2
a69eef8
* origin/master: (147 commits)
  Fix the attribute names in the docstring of GenericAlias (pythonGH-22594)
  bpo-39337: Add a test case for normalizing of codec names (pythonGH-19069)
  bpo-41557: Update Windows installer to use SQLite 3.33.0 (pythonGH-21960)
  bpo-41976: Fix the fallback to gcc of ctypes.util.find_library when using gcc>9 (pythonGH-22598)
  bpo-41306: Allow scale value to not be rounded (pythonGH-21715)
  bpo-41970: Avoid test failure in test_lib2to3 if the module is already imported (pythonGH-22595)
  bpo-41376: Fix the documentation of `site.getusersitepackages()` (pythonGH-21602)
  Revert "bpo-26680: Incorporate is_integer in all built-in and standard library numeric types (pythonGH-6121)" (pythonGH-22584)
  bpo-41923: PEP 613: Add TypeAlias to typing module (python#22532)
  Fix comment about PyObject_IsTrue. (pythonGH-22343)
  bpo-38605: Make 'from __future__ import annotations' the default (pythonGH-20434)
  bpo-41905: Add abc.update_abstractmethods() (pythonGH-22485)
  bpo-41944: No longer call eval() on content received via HTTP in the UnicodeNames tests (pythonGH-22575)
  bpo-41944: No longer call eval() on content received via HTTP in the CJK codec tests (pythonGH-22566)
  Post 3.10.0a1
  Python 3.10.0a1
  bpo-41584: clarify when the reflected method of a binary arithemtic operator is called (python#22505)
  bpo-41939: Fix test_site.test_license_exists_at_url() (python#22559)
  bpo-41774: Tweak new programming FAQ entry (pythonGH-22562)
  bpo-41936. Remove macros Py_ALLOW_RECURSION/Py_END_ALLOW_RECURSION (pythonGH-22552)
  ...
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
@E-Paine @xzy3-cdc
bpo-41306: Allow scale value to not be rounded (pythonGH-21715)
3f0137d
This fixes the test failure with Tk 6.8.10 which is caused by changes to how Tk rounds the `from`, `to` and `tickinterval` arguments. This PR uses `noconv` if the patchlevel is greater than or equal to 8.6.10 (credit to Serhiy for this idea as it is much simpler than what I previously proposed).

Going into more detail for those who want it, the Tk change was made in [commit 591f68c](tcltk/tk@591f68c) and means that the arguments listed above are rounded relative to the value of `from`. However, when rounding the `from` argument ([line 623](https://github.com/tcltk/tk/blob/591f68cb382525b72664c6fecaab87742b6cc87a/generic/tkScale.c#L623)), it is rounded relative to itself (i.e. rounding `0`) and therefore the assigned value for `from` is always what is given (no matter what values of `from` and `resolution`).

Automerge-Triggered-By: @pablogsal
@gpshead gpshead added the needs backport to 3.7 label Sep 1, 2022
@miss-islington

miss-islington commented Sep 1, 2022

Copy link
Copy Markdown
Contributor

Thanks @E-Paine for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the needs backport to 3.7 label Sep 1, 2022
@bedevere-bot

bedevere-bot commented Sep 1, 2022

Copy link
Copy Markdown

GH-96484 is a backport of this pull request to the 3.7 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 1, 2022
@E-Paine @miss-islington
bpo-41306: Allow scale value to not be rounded (pythonGH-21715)
f746777
This fixes the test failure with Tk 6.8.10 which is caused by changes to how Tk rounds the `from`, `to` and `tickinterval` arguments. This PR uses `noconv` if the patchlevel is greater than or equal to 8.6.10 (credit to Serhiy for this idea as it is much simpler than what I previously proposed).

Going into more detail for those who want it, the Tk change was made in [commit 591f68c](tcltk/tk@591f68c) and means that the arguments listed above are rounded relative to the value of `from`. However, when rounding the `from` argument ([line 623](https://github.com/tcltk/tk/blob/591f68cb382525b72664c6fecaab87742b6cc87a/generic/tkScale.cGH-L623)), it is rounded relative to itself (i.e. rounding `0`) and therefore the assigned value for `from` is always what is given (no matter what values of `from` and `resolution`).

Automerge-Triggered-By: @pablogsal
(cherry picked from commit aecf036)

Co-authored-by: E-Paine <[email protected]>
ned-deily pushed a commit that referenced this pull request Sep 1, 2022
@miss-islington @E-Paine
bpo-41306: Allow scale value to not be rounded (GH-21715) (GH-96484)
bb8e49b
This fixes the test failure with Tk 6.8.10 which is caused by changes to how Tk rounds the `from`, `to` and `tickinterval` arguments. This PR uses `noconv` if the patchlevel is greater than or equal to 8.6.10 (credit to Serhiy for this idea as it is much simpler than what I previously proposed).

Going into more detail for those who want it, the Tk change was made in [commit 591f68c](tcltk/tk@591f68c) and means that the arguments listed above are rounded relative to the value of `from`. However, when rounding the `from` argument ([line 623](https://github.com/tcltk/tk/blob/591f68cb382525b72664c6fecaab87742b6cc87a/generic/tkScale.cGH-L623)), it is rounded relative to itself (i.e. rounding `0`) and therefore the assigned value for `from` is always what is given (no matter what values of `from` and `resolution`).

Automerge-Triggered-By: @pablogsal
(cherry picked from commit aecf036)

Co-authored-by: E-Paine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka left review comments
@pablogsal pablogsal pablogsal approved these changes
@terryjreedy terryjreedy terryjreedy left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@miss-islington miss-islington

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@E-Paine @miss-islington @bedevere-bot @serhiy-storchaka @pablogsal @terryjreedy @gpshead @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.