GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-40275: Fix failed test cases by using test helpers by shihai1991 · Pull Request #21811 · python/cpython

Conversation

@shihai1991

@shihai1991 shihai1991 commented Aug 10, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

https://bugs.python.org/issue40275

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@shihai1991
Fix failed test cases by using test helpers
ec5d124
@shihai1991
shihai1991 requested a review from a team as a code owner August 10, 2020 16:02
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Aug 10, 2020
@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Aug 10, 2020
@shihai1991

shihai1991 commented Aug 10, 2020

Copy link
Copy Markdown
Member Author

cc @vstinner
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Aug 10, 2020

Copy link
Copy Markdown
Member

Sadly, all GitHub actions are skipped. My #21806 PR should fix it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner added the skip news label Aug 10, 2020
@shihai1991 shihai1991 closed this Aug 10, 2020
@shihai1991 shihai1991 reopened this Aug 10, 2020
@vstinner

vstinner commented Aug 10, 2020

Copy link
Copy Markdown
Member

Ah! It's now better with repaired GH Action jobs (no longer skipped)! I'm more confident to merge the PR. I see that macOS is green again, thanks @shihai1991!
shihai1991 reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner merged commit 490c542 into python:master Aug 10, 2020
@bedevere-bot bedevere-bot removed the awaiting review label Aug 10, 2020
shihai1991 added a commit to shihai1991/cpython that referenced this pull request Aug 20, 2020
@shihai1991
bpo-40275: Fix failed test cases by using test helpers (pythonGH-21811)
77345ae
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
@shihai1991 @xzy3-cdc
bpo-40275: Fix failed test cases by using test helpers (pythonGH-21811)
8f9179c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@shihai1991 @vstinner @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.