GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-41604: Don't decrement the reference count of the previous user_ptr when set_panel_usertpr fails by madebr · Pull Request #21933 · python/cpython

Conversation

@madebr

@madebr madebr commented Aug 21, 2020 •
edited by serhiy-storchaka
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

https://bugs.python.org/issue41604

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Aug 21, 2020
@bedevere-bot bedevere-bot added the awaiting review label Aug 21, 2020
@madebr

madebr commented Aug 21, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

I accidentally copied the wrong bug id,
It should be https://bugs.python.org/issue41604
I'll force push a fix tomorrow.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@madebr
bpo-41604: Don't decrement the reference count of the previous user_p…
39a4378 
…tr when set_panel_usertpr fails
@madebr
madebr force-pushed the panel_set_userptr branch from 64bfd04 to 39a4378 Compare August 21, 2020 13:25
@serhiy-storchaka serhiy-storchaka added needs backport to 3.8 type-bug An unexpected behavior, bug, or error labels Jan 6, 2021
@serhiy-storchaka
Merge branch 'master' into panel_set_userptr
892c87f
serhiy-storchaka
serhiy-storchaka approved these changes Jan 6, 2021
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Jan 6, 2021
@serhiy-storchaka serhiy-storchaka changed the title bpo-1723038: Don't decrement the reference count of the previous user_ptr when set_panel_usertpr fails bpo-41604: Don't decrement the reference count of the previous user_ptr when set_panel_usertpr fails Jan 31, 2021
@serhiy-storchaka
serhiy-storchaka merged commit 3243e8a into python:master Jan 31, 2021
@miss-islington

miss-islington commented Jan 31, 2021

Copy link
Copy Markdown
Contributor

Thanks @madebr for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Jan 31, 2021
@miss-islington

miss-islington commented Jan 31, 2021

Copy link
Copy Markdown
Contributor

Sorry, @madebr and @serhiy-storchaka, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 3243e8a4b4b4cf321f9b28335d565742a34b1976 3.9
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington miss-islington assigned serhiy-storchaka Jan 31, 2021
@miss-islington

miss-islington commented Jan 31, 2021

Copy link
Copy Markdown
Contributor

Sorry @madebr and @serhiy-storchaka, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 3243e8a4b4b4cf321f9b28335d565742a34b1976 3.8
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
serhiy-storchaka pushed a commit to serhiy-storchaka/cpython that referenced this pull request Jan 31, 2021
@madebr @serhiy-storchaka
[3.9] bpo-41604: Don't decrement the reference count of the previous …
e178858 
…user_ptr when set_panel_usertpr fails (pythonGH-21933).

(cherry picked from commit 3243e8a)

Co-authored-by: Anonymous Maarten <[email protected]>
@bedevere-bot

bedevere-bot commented Jan 31, 2021

Copy link
Copy Markdown

GH-24403 is a backport of this pull request to the 3.9 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.9 label Jan 31, 2021
@serhiy-storchaka serhiy-storchaka removed their assignment Jan 31, 2021
@serhiy-storchaka serhiy-storchaka removed the needs backport to 3.8 label Jan 31, 2021
@madebr
madebr deleted the panel_set_userptr branch January 31, 2021 19:01
serhiy-storchaka added a commit that referenced this pull request Jan 31, 2021
@serhiy-storchaka @madebr
[3.9] bpo-41604: Don't decrement the reference count of the previous …
3c8d693 
…user_ptr when set_panel_usertpr fails (GH-21933). (GH-24403)

(cherry picked from commit 3243e8a)

Co-authored-by: Anonymous Maarten <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 31, 2021
@serhiy-storchaka @miss-islington
[3.9] bpo-41604: Don't decrement the reference count of the previous …
34d56e9 
…user_ptr when set_panel_usertpr fails (pythonGH-21933). (pythonGH-24403)

(cherry picked from commit 3243e8a)

Co-authored-by: Anonymous Maarten <[email protected]>
(cherry picked from commit 3c8d693)

Co-authored-by: Serhiy Storchaka <[email protected]>
miss-islington added a commit that referenced this pull request Jan 31, 2021
@miss-islington @serhiy-storchaka
[3.9] bpo-41604: Don't decrement the reference count of the previous …
931263b 
…user_ptr when set_panel_usertpr fails (GH-21933). (GH-24403)

(cherry picked from commit 3243e8a)

Co-authored-by: Anonymous Maarten <[email protected]>
(cherry picked from commit 3c8d693)

Co-authored-by: Serhiy Storchaka <[email protected]>
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@madebr @adorilson
bpo-41604: Don't decrement the reference count of the previous user_p…
78c6491 
…tr when set_panel_usertpr fails (pythonGH-21933)
@ffrederick ffrederick mannequin mentioned this pull request Apr 10, 2022
Curses Menu #44985
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@madebr @miss-islington @bedevere-bot @serhiy-storchaka @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.