GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-40077: Convert _operator to use PyType_FromSpec by corona10 · Pull Request #21954 · python/cpython

Conversation

@corona10

@corona10 corona10 commented Aug 25, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

https://bugs.python.org/issue40077

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@corona10
bpo-40077: Convert _operaator to use PyType_FromSpec
c27c26b
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Aug 25, 2020
@bedevere-bot bedevere-bot added the awaiting core review label Aug 25, 2020
@corona10
corona10 requested a review from vstinner August 25, 2020 14:02
@corona10

corona10 commented Aug 25, 2020

Copy link
Copy Markdown
Member Author

@shihai1991 Can you please take a look also?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
shihai1991
shihai1991 approved these changes Aug 25, 2020
View reviewed changes

@shihai1991 shihai1991 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@corona10 corona10 changed the title bpo-40077: Convert _operaator to use PyType_FromSpec bpo-40077: Convert _operator to use PyType_FromSpec Aug 26, 2020
vstinner
vstinner approved these changes Aug 26, 2020
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, well done :-) It's easy to forget small things in such refactoring.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Aug 26, 2020
@corona10
corona10 merged commit 31967fd into python:master Aug 26, 2020
@bedevere-bot bedevere-bot removed the awaiting merge label Aug 26, 2020
@corona10
corona10 deleted the bpo-40077-operator branch August 26, 2020 17:22
@vstinner

vstinner commented Aug 27, 2020

Copy link
Copy Markdown
Member

Thanks @corona10.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
@corona10 @xzy3-cdc
bpo-40077: Convert _operator to use PyType_FromSpec (pythonGH-21954)
20bba8b
@corona10 corona10 mentioned this pull request Jun 27, 2022
Convert static types to heap types: use PyType_FromSpec() #84258
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes
@shihai1991 shihai1991 shihai1991 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@corona10 @vstinner @shihai1991 @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.