GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

GeezerVison is showing github.com — [3.5] bpo-29532: Altering a kwarg dictionary passed to functools.partial() no longer affects a partial object after creation. by serhiy-storchaka · Pull Request #222 · python/cpython

Conversation

serhiy-storchaka commented Feb 21, 2017

Copy link

Copy Markdown

Member

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

serhiy-storchaka added 2 commits

February 21, 2017 22:09


          bpo-29532: Altering a kwarg dictionary passed to functools.partial() …

8a5d5c8

…no longer affects a partial object after creation. (python#209)


          Fix Misc/NEWS.

372a25c

serhiy-storchaka added type-bug

An unexpected behavior, bug, or error

cherry-pick for 3.5 labels

the-knights-who-say-ni added the CLA signed label

codecov Bot commented Feb 21, 2017

Copy link

Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (3.5@9ab8eaf). Click here to learn what that means.
The diff coverage is 100%.

@@          Coverage Diff           @@
##             3.5     #222   +/-   ##
======================================
  Coverage       ?   82.42%           
======================================
  Files          ?     1404           
  Lines          ?   341460           
  Branches       ?        0           
======================================
  Hits           ?   281432           
  Misses         ?    60028           
  Partials       ?        0

Impacted Files	Coverage Δ
Lib/test/test_functools.py	`94.43% <100%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ab8eaf...372a25c. Read the comment docs.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

zhangyangyu approved these changes

View reviewed changes

serhiy-storchaka merged commit 5010a77 into python:3.5

serhiy-storchaka deleted the bpo29532-py35 branch

February 22, 2017 09:46

Mariatta mentioned this pull request

bpo-29532: Altering a kwarg dictionary passed to functools.partial() #190

Merged

akruis added a commit to akruis/cpython that referenced this pull request


          Stackless issue python#222: Fix a typo test_otside2 -> test_outside2

acfc710

akruis added a commit to akruis/cpython that referenced this pull request


          Stackless issue python#222: Support code for testing C-stack serial n…

4f7b3ec

…umbers

Allow the Stackless test suite to access 
- PyThreadState fields st.serial, st.serial_last_jump, st.initial_stub
- PyCStackObject attribute serial
Intentionally undocumented

akruis added a commit to akruis/cpython that referenced this pull request


          Stackless issue python#222: fix main-tasklet termination with serial …

0b8da63

…mismatch

Fix the termination of a main-tasklet when serial_last_jump !=
initial_stub.serial. This caused an assertion failure and a reference
leak.

akruis added a commit to akruis/cpython that referenced this pull request


          Stackless issue python#222: add a test case

a0f56e7

Add a test case for a main tasklet, that terminates with
serial_last_jump != initial_stub.serial.

akruis added a commit to akruis/cpython that referenced this pull request


          Stackless issue python#222: Fix a typo test_otside2 -> test_outside2

e68602d

(cherry picked from commit acfc710)

akruis added a commit to akruis/cpython that referenced this pull request


          Stackless issue python#222: fix main-tasklet termination with serial …

39983ac

…mismatch

Fix the termination of a main-tasklet when serial_last_jump !=
initial_stub.serial. This caused an assertion failure and a reference
leak.

(cherry picked from commit 0b8da63)

akruis added a commit to akruis/cpython that referenced this pull request


          Stackless issue python#222: Fix a typo test_otside2 -> test_outside2

48cacfc

(cherry picked from commit acfc710)

akruis added a commit to akruis/cpython that referenced this pull request


          Stackless issue python#222: Support code for testing C-stack serial n…

bffe80b

…umbers

Allow the Stackless test suite to access
- PyThreadState fields st.serial, st.serial_last_jump, st.initial_stub
- PyCStackObject attribute serial
Intentionally undocumented

(cherry picked from commit 4f7b3ec)

akruis added a commit to akruis/cpython that referenced this pull request


          Stackless issue python#222: fix main-tasklet termination with serial …

6ab2e5b

…mismatch

Fix the termination of a main-tasklet when serial_last_jump !=
initial_stub.serial. This caused an assertion failure and a reference
leak.

(cherry picked from commit 0b8da63)

akruis added a commit to akruis/cpython that referenced this pull request


          Stackless issue python#222: add a test case

95b4c30

Add a test case for a main tasklet, that terminates with
serial_last_jump != initial_stub.serial.
(cherry picked from commit a0f56e7)

ahgamut pushed a commit to ahgamut/cpython that referenced this pull request


          Stackless issue python#222: Fix a typo test_otside2 -> test_outside2

b345193

(cherry picked from commit acfc710)

ahgamut pushed a commit to ahgamut/cpython that referenced this pull request


          Stackless issue python#222: fix main-tasklet termination with serial …

8e9dc36

…mismatch

Fix the termination of a main-tasklet when serial_last_jump !=
initial_stub.serial. This caused an assertion failure and a reference
leak.

(cherry picked from commit 0b8da63)

jaraco added a commit to jaraco/cpython that referenced this pull request


          Merge pull request python#222 from python/feature/unique-everseen

064fa89

Implement MultiplexedPath.iterdir using 'unique_everseen'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

zhangyangyu approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.