GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-41919: Move the codecs.register operation to the setup of testcases. by shihai1991 · Pull Request #22513 · python/cpython

Conversation

@shihai1991

@shihai1991 shihai1991 commented Oct 3, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Move the codecs.register operation to the setup of testcases.
  • Remove _codecs._forget_codecs and _PyCodec_Forget().

https://bugs.python.org/issue41919

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@shihai1991
Move the codecs' (un)register operation to testcases.
1639b30
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Oct 3, 2020
@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Oct 3, 2020
@corona10 corona10 added the skip news label Oct 3, 2020
@shihai1991

shihai1991 commented Oct 3, 2020

Copy link
Copy Markdown
Member Author

Hi, victor. Pls take a look when you have free time. @vstinner
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner
vstinner reviewed Oct 3, 2020
View reviewed changes
Comment thread Lib/test/test_codecs.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/test/test_codecs.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@shihai1991
Remove _codecs._forget_codec() and _PyCodec_Forget()
1feb480
@shihai1991 shihai1991 changed the title bpo-41919: Move the codecs.register operation to testcases. bpo-41919: Move the codecs.register operation to the inside of testcases. Oct 8, 2020
@shihai1991 shihai1991 changed the title bpo-41919: Move the codecs.register operation to the inside of testcases. bpo-41919: Move the codecs.register operation to the setup of testcases. Oct 8, 2020
vstinner
vstinner approved these changes Oct 8, 2020
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I checked for leaks: ./python -m test test_codecs -R 3:3 pass (no leak), good!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Oct 8, 2020
@vstinner vstinner mentioned this pull request Oct 8, 2020
Please make Travis CI optional again python/core-workflow#377
Closed
@shihai1991 shihai1991 closed this Oct 15, 2020
@shihai1991 shihai1991 reopened this Oct 15, 2020
@vstinner

vstinner commented Oct 15, 2020

Copy link
Copy Markdown
Member

It seems like your PR is sick: it got two Travis CI, and one will never complete. It's a victim of python/core-workflow#377 bug.

Can you try to recreate a new PR? For example, rename your local branch update_test_codecs to update_test_codecs2 and publish it.

Or wait until python/core-workflow#377 is fixed (Travis CI made optional).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@shihai1991

shihai1991 commented Oct 15, 2020

Copy link
Copy Markdown
Member Author

It seems like your PR is sick: it got two Travis CI, and one will never complete. It's a victim of python/core-workflow#377 bug.

Can you try to recreate a new PR? For example, rename your local branch update_test_codecs to update_test_codecs2 and publish it.

Or wait until python/core-workflow#377 is fixed (Travis CI made optional).

Copy that, I can waiting the fix of issues/377 :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner merged commit c9f696c into python:master Oct 16, 2020
@bedevere-bot bedevere-bot removed the awaiting merge label Oct 16, 2020
@vstinner

vstinner commented Oct 16, 2020

Copy link
Copy Markdown
Member

Copy that, I can waiting the fix of issues/377 :)

Travis CI is no longer mandatory.

I merged your PR, thanks.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@shihai1991

shihai1991 commented Oct 16, 2020

Copy link
Copy Markdown
Member Author

Copy that, I can waiting the fix of issues/377 :)

Travis CI is no longer mandatory.

I merged your PR, thanks.

Wow, thanks, victor.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
@shihai1991 @xzy3-cdc
bpo-41919, test_codecs: Move codecs.register calls to setUp() (python…
9011f3f 
…GH-22513)

* Move the codecs' (un)register operation to testcases.
* Remove _codecs._forget_codec() and _PyCodec_Forget()
pablogsal added a commit that referenced this pull request Oct 25, 2020
@pablogsal
Revert "bpo-41919, test_codecs: Move codecs.register calls to setUp() (…
b1c9a20 
…GH-22513)"

This reverts commit c9f696c.
@pablogsal pablogsal mentioned this pull request Oct 25, 2020
bpo-41919: Revert "bpo-41919: Move the codecs.register operation to the setup of testcases." #22961
Closed
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@shihai1991 @adorilson
bpo-41919, test_codecs: Move codecs.register calls to setUp() (python…
e00b598 
…GH-22513)

* Move the codecs' (un)register operation to testcases.
* Remove _codecs._forget_codec() and _PyCodec_Forget()
@shihai1991 shihai1991 mentioned this pull request Apr 10, 2022
Modify test_codecs to use the new codecs.unregister() function #86085
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@shihai1991 @vstinner @corona10 @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.