GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [doc] Use list[int] instead of List[int] (etc.) in a few more places by andresdelfino · Pull Request #22524 · python/cpython

Conversation

@andresdelfino

@andresdelfino andresdelfino commented Oct 3, 2020 •
edited by miss-islington
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This changes a few occurrences left behind by #22340.

Automerge-Triggered-By: @gvanrossum

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@andresdelfino
Use new generic types
0f2820a
@andresdelfino
andresdelfino requested review from gvanrossum and ilevkivskyi as code owners October 3, 2020 16:22
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Oct 3, 2020
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Oct 3, 2020
@andresdelfino
Use new generic types
662dfba
@andresdelfino
andresdelfino requested a review from ericvsmith as a code owner October 3, 2020 16:26
gvanrossum
gvanrossum approved these changes Oct 3, 2020
View reviewed changes

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You wouldn't be collecting points for HacktoberFest would you? :-) I wish you had combined all those little patches into one PR.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Oct 3, 2020
@gvanrossum gvanrossum changed the title [doc] Leverage the fact that the actual types can now be indexed for typing [doc] Use list[int] instead of List[int] (etc.) in a few more places Oct 3, 2020
@gvanrossum gvanrossum added 🤖 automerge skip issue skip news labels Oct 3, 2020
@miss-islington
miss-islington merged commit 7f54e56 into python:master Oct 3, 2020
@miss-islington

miss-islington commented Oct 3, 2020

Copy link
Copy Markdown
Contributor

@andresdelfino: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
1 similar comment
@miss-islington

miss-islington commented Oct 3, 2020

Copy link
Copy Markdown
Contributor

@andresdelfino: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Oct 3, 2020

Copy link
Copy Markdown
Contributor

Sorry, I can't merge this PR. Reason: Pull Request is not mergeable.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
1 similar comment
@miss-islington

miss-islington commented Oct 3, 2020

Copy link
Copy Markdown
Contributor

Sorry, I can't merge this PR. Reason: Pull Request is not mergeable.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Oct 3, 2020

Copy link
Copy Markdown
Contributor

Thanks @andresdelfino for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Oct 3, 2020
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 3, 2020
@andresdelfino @miss-islington
[doc] Use list[int] instead of List[int] (etc.) in a few more places (p…
8e7e21b 
…ythonGH-22524)

This changes a few occurrences left behind by pythonGH-22340.

Automerge-Triggered-By: @gvanrossum
(cherry picked from commit 7f54e56)

Co-authored-by: Andre Delfino <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.9 label Oct 3, 2020
@bedevere-bot

bedevere-bot commented Oct 3, 2020

Copy link
Copy Markdown

GH-22531 is a backport of this pull request to the 3.9 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@andresdelfino

andresdelfino commented Oct 3, 2020

Copy link
Copy Markdown
Contributor Author

You wouldn't be collecting points for HacktoberFest would you? :-) I wish you had combined all those little patches into one PR.

Yeah, the thing is that I'm doing a talk on type hints soon (quite excited about this :) and I'm reading the docs meticulously, so I'm finding occurrences I previously didn't get by by just grepping it :P

Sorry about that.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@andresdelfino
andresdelfino deleted the use_actual_generic_types_2 branch October 3, 2020 22:12
@gvanrossum

gvanrossum commented Oct 3, 2020

Copy link
Copy Markdown
Member

Awesome, thanks for all the doc fixes, good luck with the talk!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington added a commit that referenced this pull request Oct 3, 2020
@miss-islington @andresdelfino
[doc] Use list[int] instead of List[int] (etc.) in a few more places (G…
5f9a08d 
…H-22524)

This changes a few occurrences left behind by GH-22340.

Automerge-Triggered-By: @gvanrossum
(cherry picked from commit 7f54e56)

Co-authored-by: Andre Delfino <[email protected]>
ambv pushed a commit to ambv/cpython that referenced this pull request Oct 4, 2020
@miss-islington @andresdelfino @ambv
[doc] Use list[int] instead of List[int] (etc.) in a few more places (p…
fd510e3 
…ythonGH-22524)

This changes a few occurrences left behind by pythonGH-22340.

Automerge-Triggered-By: @gvanrossum
(cherry picked from commit 7f54e56)

Co-authored-by: Andre Delfino <[email protected]>
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
@andresdelfino @xzy3-cdc
[doc] Use list[int] instead of List[int] (etc.) in a few more places (p…
39b5ae0 
…ythonGH-22524)

This changes a few occurrences left behind by python#22340.

Automerge-Triggered-By: @gvanrossum
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes
@ilevkivskyi ilevkivskyi Awaiting requested review from ilevkivskyi
@ericvsmith ericvsmith Awaiting requested review from ericvsmith

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@andresdelfino @miss-islington @bedevere-bot @gvanrossum @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.