GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.5] bpo-29554: Improve docs for pstat module and profile. (#88) by berkerpeksag · Pull Request #228 · python/cpython

Conversation

@berkerpeksag

@berkerpeksag berkerpeksag commented Feb 21, 2017

Copy link
Copy Markdown
Member

Clarify that methods take a string which is interpreted as a regex,
not a regex object.

Also clarify what the old -1, 0, 1 and 2 options were.

(cherry picked from commit 8fb1f6e)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Carreau @berkerpeksag
bpo-29554: Improve docs for pstat module and profile. (python#88)
7661098 
Clarify that methods take a string which is interpreted as a regex,
not a regex object.

Also clarify what the old `-1`, `0`, `1` and `2` options were.
(cherry picked from commit 8fb1f6e)
@berkerpeksag berkerpeksag added the cherry-pick for 3.5 label Feb 21, 2017
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Feb 21, 2017
Mariatta
Mariatta approved these changes Feb 22, 2017
View reviewed changes
@codecov

codecov Bot commented Feb 22, 2017

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (3.5@9ab8eaf). Click here to learn what that means.
The diff coverage is n/a.

@@          Coverage Diff           @@
##             3.5     #228   +/-   ##
======================================
  Coverage       ?   82.41%           
======================================
  Files          ?     1404           
  Lines          ?   341454           
  Branches       ?        0           
======================================
  Hits           ?   281423           
  Misses         ?    60031           
  Partials       ?        0
Impacted Files Coverage Δ
Lib/pstats.py 58.72% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ab8eaf...7661098. Read the comment docs.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@berkerpeksag
berkerpeksag merged commit 6336f0d into python:3.5 Feb 22, 2017
@berkerpeksag
berkerpeksag deleted the 88-backport-3.5 branch February 22, 2017 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mariatta Mariatta Mariatta approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@berkerpeksag @Mariatta @the-knights-who-say-ni @Carreau
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.