GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||
GeezerVison is showing github.com — bpo-29554: Improve docs for pstat module and profile. by Carreau · Pull Request #88 · python/cpython Conversation
|
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
As the rewrapping make a lot of line changes:
or a string that will interpreted as a regular expression
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
I'd recommend redoing the PR as a commit to make the change(s) you want and a commit to rewrap. That way the change can be reviewed more easily.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Ohhhh ! Why did I never thought of that. Done.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
add:
that are respectively interpreted as 'stdname', 'calls', 'time', and 'cumulative'
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
and to , and add and sort_arg_dict_default
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
This requires a new tracker item on bugs.python.org. See step 5 at http://cpython-devguide.readthedocs.io/#quick-start for details. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Thank you, I thought that was minor enough. but done as bpo-29554 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't "(to pattern match the standard name that is printed." be end with a closing parenthesis ?
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Yes. Done.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
There are multiple whitespaces between "respectively interpreted".
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Good eyes !
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Instead of breaking sort_stats('time', 'name') call I'd move the "For example [...]" sentence to its own paragraph.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Done as well.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Codecov Report
@@ Coverage Diff @@ ## master #88 +/- ## ========================================== - Coverage 83.38% 82.38% -1.01% ========================================== Files 1367 1428 +61 Lines 344903 351138 +6235 ========================================== + Hits 287604 289284 +1680 - Misses 57299 61854 +4555 Continue to review full report at Codecov.
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Clarify that methods takes a string which is interpreted as a re, and not a re object. Clarify what the old `-1`, `0`, `1` and `2` option were.
Re wrap as a second commit, to make review easier.
|
Thanks! |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Thanks, much appreciated. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Clarify that methods take a string which is interpreted as a regex, not a regex object. Also clarify what the old `-1`, `0`, `1` and `2` options were. (cherry picked from commit 8fb1f6e)
Clarify that methods take a string which is interpreted as a regex, not a regex object. Also clarify what the old `-1`, `0`, `1` and `2` options were. (cherry picked from commit 8fb1f6e)
stackless.current.switch() Fix an assertion violation caused by incorrect usage of ts->st.del_post_switch. Add a test case for "switch to current". This commit also adds the test class TestTaskletSwitching, which was only in 2.7-slp. https://bitbucket.org/stackless-dev/stackless/issues/88 (grafted from f0db3bdf1061, b85b07e9f10effdbf52adc71d452d1e93bd3c5fd, 782a1b292460 and 7d9b4398011f)
The object's thread-id may be zero by the time _Py_queue_object is called. Get the thread-id before marking the object as queued in _Py_DecRefShared. Fixes #88
…ation fabrication Adds a script symmetric to scripts/numstat_bundle.sh that mechanizes the "is this symbol called anywhere?" check, so dead-code-deletion recommendations can no longer fail by quoting a head-truncated grep that misses callers in sibling subtrees. Per pythia python#88 + supervisor L2603 mechanization directive: theologian's head-truncation incident (L2581) was caught by medic only because she happened to re-grep independently. Mechanize the check so future similar slips are caught by tooling, not by chance. Discipline mechanized: - Searches the whole built source tree (Python Include Tools Lib Modules Programs), NOT just /Python/jit/. - NO head/tail truncation; full output to stdout. - Reports total + per-file count + verbatim grep cmd, so the caller can paste the result into chat without paraphrase. - Verdict line: ACTIVE / DEAD-CODE CANDIDATE. - Optional --exclude=<regex> for tagged-variant disambiguation (e.g. PhyRegisterSet vs RegisterSet). VALIDATION (2 tests against the actual incident): TEST 1 — would have prevented the L2581 fabrication: scripts/caller_grep.sh 'hir::Simplify\\{\\}' -> ACTIVE: 3 caller(s) across 1 file(s) -> Python/jit/compiler.cpp:106,120,128 -> Verdict: 'DO NOT delete without rewiring callers first.' TEST 2 — confirms Batch 2-A analysis was sound: scripts/caller_grep.sh '\\bRegisterSet\\b' --exclude='PhyRegisterSet' -> 0 lines across 0 files -> Verdict: 'DEAD-CODE CANDIDATE' Both verdicts match medic L2583 + theologian L2591 manual-grep results.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.