GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-29554: Improve docs for pstat module and profile. by Carreau · Pull Request #88 · python/cpython

Conversation

@Carreau

@Carreau Carreau commented Feb 14, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Clarify that methods takes a string which is interpreted as a re, and
not a re object.

Clarify what the old -1, 0, 1 and 2 option were.

bpo-29554

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Feb 14, 2017
@Carreau
Carreau force-pushed the pstat-docs branch from 118fee0 to 34b1bcc Compare February 14, 2017 04:48
Carreau
Carreau commented Feb 14, 2017
View reviewed changes
Comment thread Doc/library/profile.rst Outdated

@Carreau Carreau Feb 14, 2017

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the rewrapping make a lot of line changes:

or a string that will interpreted as a regular expression

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

@zware zware Feb 14, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd recommend redoing the PR as a commit to make the change(s) you want and a commit to rewrap. That way the change can be reviewed more easily.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

@Carreau Carreau Feb 14, 2017

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohhhh ! Why did I never thought of that. Done.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread Lib/pstats.py Outdated

@Carreau Carreau Feb 14, 2017

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add:

that are respectively interpreted as 'stdname', 'calls', 'time', and 'cumulative'

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread Lib/pstats.py Outdated

@Carreau Carreau Feb 14, 2017

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and to , and add and sort_arg_dict_default

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@Carreau
Carreau force-pushed the pstat-docs branch from 34b1bcc to 697071d Compare February 14, 2017 05:56
@berkerpeksag

berkerpeksag commented Feb 14, 2017

Copy link
Copy Markdown
Member

This requires a new tracker item on bugs.python.org. See step 5 at http://cpython-devguide.readthedocs.io/#quick-start for details.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Carreau Carreau changed the title Improve docs for pstat module and profile. bpo-29554 : Improve docs for pstat module and profile. Feb 14, 2017
@Carreau

Carreau commented Feb 14, 2017

Copy link
Copy Markdown
Contributor Author

This requires a new tracker item on bugs.python.org. See step 5 at http://cpython-devguide.readthedocs.io/#quick-start for details.

Thank you, I thought that was minor enough. but done as bpo-29554

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

brettcannon
brettcannon approved these changes Feb 15, 2017
View reviewed changes
berkerpeksag
berkerpeksag reviewed Feb 19, 2017
View reviewed changes
Comment thread Doc/library/profile.rst Outdated

@berkerpeksag berkerpeksag Feb 19, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't "(to pattern match the standard name that is printed." be end with a closing parenthesis ?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

@Carreau Carreau Feb 20, 2017

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Done.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread Lib/pstats.py Outdated

@berkerpeksag berkerpeksag Feb 19, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are multiple whitespaces between "respectively interpreted".

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

@Carreau Carreau Feb 20, 2017

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good eyes !

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread Lib/pstats.py Outdated

@berkerpeksag berkerpeksag Feb 19, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of breaking sort_stats('time', 'name') call I'd move the "For example [...]" sentence to its own paragraph.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

@Carreau Carreau Feb 20, 2017

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done as well.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@berkerpeksag berkerpeksag added needs backport to 3.5 labels Feb 19, 2017
@berkerpeksag berkerpeksag changed the title bpo-29554 : Improve docs for pstat module and profile. bpo-29554: Improve docs for pstat module and profile. Feb 19, 2017
@Carreau
Carreau force-pushed the pstat-docs branch from 697071d to 5948aa3 Compare February 20, 2017 23:20
@codecov

codecov Bot commented Feb 20, 2017

Copy link
Copy Markdown

Codecov Report

Merging #88 into master will decrease coverage by -1.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #88      +/-   ##
==========================================
- Coverage   83.38%   82.38%   -1.01%     
==========================================
  Files        1367     1428      +61     
  Lines      344903   351138    +6235     
==========================================
+ Hits       287604   289284    +1680     
- Misses      57299    61854    +4555

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 112ec38...5948aa3. Read the comment docs.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Carreau added 2 commits February 20, 2017 15:20
@Carreau
Improve docs for pstat module and profile.
2929235
Clarify that methods takes a string which is interpreted as a re, and
not a re object.

Clarify what the old `-1`, `0`, `1` and `2` option were.
@Carreau
Rewrap paragraph
29c6e72
Re wrap as a second commit, to make review easier.
@Carreau
Carreau force-pushed the pstat-docs branch from 5948aa3 to 29c6e72 Compare February 20, 2017 23:21
berkerpeksag
berkerpeksag approved these changes Feb 21, 2017
View reviewed changes
@berkerpeksag
berkerpeksag merged commit 8fb1f6e into python:master Feb 21, 2017
@berkerpeksag

berkerpeksag commented Feb 21, 2017

Copy link
Copy Markdown
Member

Thanks!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Carreau
Carreau deleted the pstat-docs branch February 21, 2017 16:51
@Carreau

Carreau commented Feb 21, 2017

Copy link
Copy Markdown
Contributor Author

Thanks, much appreciated.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

berkerpeksag pushed a commit to berkerpeksag/cpython that referenced this pull request Feb 21, 2017
@Carreau @berkerpeksag
bpo-29554: Improve docs for pstat module and profile. (python#88)
5dfaa29
Clarify that methods take a string which is interpreted as a regex,
not a regex object.

Also clarify what the old `-1`, `0`, `1` and `2` options were.
(cherry picked from commit 8fb1f6e)
berkerpeksag pushed a commit to berkerpeksag/cpython that referenced this pull request Feb 21, 2017
@Carreau @berkerpeksag
bpo-29554: Improve docs for pstat module and profile. (python#88)
7661098
Clarify that methods take a string which is interpreted as a regex,
not a regex object.

Also clarify what the old `-1`, `0`, `1` and `2` options were.
(cherry picked from commit 8fb1f6e)
@berkerpeksag berkerpeksag removed needs backport to 3.5 labels Feb 21, 2017
berkerpeksag added a commit that referenced this pull request Feb 22, 2017
@berkerpeksag
bpo-29554: Improve docs for pstat module and profile. (#88) (#228)
6336f0d
Clarify that methods take a string which is interpreted as a regex,
not a regex object.

Also clarify what the old `-1`, `0`, `1` and `2` options were.

(cherry picked from commit 8fb1f6e)
berkerpeksag added a commit that referenced this pull request Feb 22, 2017
@berkerpeksag
bpo-29554: Improve docs for pstat module and profile. (#88) (#227)
b067a5e
Clarify that methods take a string which is interpreted as a regex,
not a regex object.

Also clarify what the old `-1`, `0`, `1` and `2` options were.

(cherry picked from commit 8fb1f6e)
akruis pushed a commit to akruis/cpython that referenced this pull request Sep 9, 2017
Anselm Kruis
Stackless issue python#88: Fix assertion violation caused by
a527058
stackless.current.switch()

Fix an assertion violation caused by incorrect usage of
ts->st.del_post_switch.
Add a test case for "switch to current".

This commit also adds the test class TestTaskletSwitching, which was
only in 2.7-slp.

https://bitbucket.org/stackless-dev/stackless/issues/88
(grafted from f0db3bdf1061, b85b07e9f10effdbf52adc71d452d1e93bd3c5fd, 782a1b292460
and 7d9b4398011f)
colesbury referenced this pull request in colesbury/nogil Oct 6, 2021
@colesbury
Fix race between _Py_MergeZeroRefcount and _Py_DecRefShared
92d314d
The object's thread-id may be zero by the time _Py_queue_object is
called. Get the thread-id before marking the object as queued in
_Py_DecRefShared.

Fixes #88
jaraco added a commit to jaraco/cpython that referenced this pull request Feb 17, 2023
@jaraco
Ensure trees module is imported. Closes python#88.
3b5d345
@gvanrossum gvanrossum mentioned this pull request Aug 22, 2023
heap-use-after-free in _PyFunction_LookupByVersion #108253
Closed
@ngoldbaum ngoldbaum mentioned this pull request Sep 23, 2024
Crash running PyO3 tests with --test-threads=1000 #124375
Closed
This was referenced Feb 11, 2025
segmentfault when pip installing setuptools #129992
Closed
segmentfault when pip installing setuptools #129993
Closed
@sergey-miryanov sergey-miryanov mentioned this pull request Dec 18, 2025
Observed memory leak in ssl library: Python 3.14 GC issue #142516
Closed
SonicField added a commit to SonicField/cpython that referenced this pull request Apr 23, 2026
@SonicField
scripts/caller_grep.sh: mechanize caller-search to prevent head-trunc…
4cfd894
…ation fabrication

Adds a script symmetric to scripts/numstat_bundle.sh that mechanizes
the "is this symbol called anywhere?" check, so dead-code-deletion
recommendations can no longer fail by quoting a head-truncated grep
that misses callers in sibling subtrees.

Per pythia python#88 + supervisor L2603 mechanization directive: theologian's
head-truncation incident (L2581) was caught by medic only because she
happened to re-grep independently. Mechanize the check so future similar
slips are caught by tooling, not by chance.

Discipline mechanized:
  - Searches the whole built source tree (Python Include Tools Lib
    Modules Programs), NOT just /Python/jit/.
  - NO head/tail truncation; full output to stdout.
  - Reports total + per-file count + verbatim grep cmd, so the caller
    can paste the result into chat without paraphrase.
  - Verdict line: ACTIVE / DEAD-CODE CANDIDATE.
  - Optional --exclude=<regex> for tagged-variant disambiguation
    (e.g. PhyRegisterSet vs RegisterSet).

VALIDATION (2 tests against the actual incident):

TEST 1 — would have prevented the L2581 fabrication:
    scripts/caller_grep.sh 'hir::Simplify\\{\\}'
    -> ACTIVE: 3 caller(s) across 1 file(s)
    -> Python/jit/compiler.cpp:106,120,128
    -> Verdict: 'DO NOT delete without rewiring callers first.'

TEST 2 — confirms Batch 2-A analysis was sound:
    scripts/caller_grep.sh '\\bRegisterSet\\b' --exclude='PhyRegisterSet'
    -> 0 lines across 0 files
    -> Verdict: 'DEAD-CODE CANDIDATE'

Both verdicts match medic L2583 + theologian L2591 manual-grep results.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zware zware zware left review comments
@berkerpeksag berkerpeksag berkerpeksag approved these changes
@brettcannon brettcannon brettcannon approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@Carreau @berkerpeksag @brettcannon @zware @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.