GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-1635741: Port _csv to multi-phase init by encukou · Pull Request #22838 · python/cpython

Conversation

@encukou

@encukou encukou commented Oct 20, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This PR depends on #22835 and shows how the new _PyType_GetModuleByDef can be used. I would love these to go in as two separate commits.

https://bugs.python.org/issue1635741

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
encukou and others added 2 commits October 20, 2020 22:45
@encukou
Add _PyType_GetModuleByDef
0b0d93c
@encukou Marcel Plch
@eduardo-elizondo @shihai1991
Remove static state from the _csv module
7b33be1 
Uses code from: python#16078

Co-authored-by: Marcel Plch <[email protected]>
Co-authored-by: Eddie Elizondo <[email protected]>
Co-authored-by: Hai Shi <[email protected]>
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Oct 20, 2020
@bedevere-bot bedevere-bot added the awaiting core review label Oct 20, 2020
This was referenced Oct 20, 2020
bpo-42100: Add _PyType_GetModuleByDef #22835
Merged
bpo-34533: Remove all static state from _csv module #16078
Closed
koubaa
koubaa reviewed Oct 21, 2020
View reviewed changes
Comment thread Objects/typeobject.c
assert(PyType_Check(type));
assert(type->tp_mro);
int i;
for (i = 0; i < PyTuple_GET_SIZE(type->tp_mro); i++) {

@koubaa koubaa Oct 21, 2020

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to call PyTuple_GET_SIZE before the for loop to only call it once.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@encukou encukou Oct 21, 2020

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a macro for direct field access, so it doesn't really matter.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@encukou
encukou marked this pull request as ready for review November 10, 2020 13:51
@encukou
encukou requested a review from markshannon as a code owner November 10, 2020 13:51
@encukou
encukou changed the base branch from master to 3.9 November 10, 2020 13:53
@encukou
encukou requested review from 1st1, abalkin, asvetlov, berkerpeksag, brettcannon, ericsnowcurrently, ericvsmith, ethanfurman, ezio-melotti, gpshead, gvanrossum, ilevkivskyi, lysnikolaou, methane, ncoghlan, pablogsal, pganssle, rhettinger, terryjreedy and tiran as code owners November 10, 2020 13:53
@encukou
encukou requested review from a team, vsajip and warsaw as code owners November 10, 2020 13:53
@encukou
encukou changed the base branch from 3.9 to master November 10, 2020 13:53
@encukou

encukou commented Nov 10, 2020

Copy link
Copy Markdown
Member Author

Apologies for the mass review requests. I'll open a new PR.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou encukou closed this Nov 10, 2020
@kylotan kylotan mannequin mentioned this pull request Sep 19, 2022
Py_Finalize() doesn't clear all Python objects at exit #44470
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon Awaiting requested review from markshannon
@1st1 1st1 Awaiting requested review from 1st1
@abalkin abalkin Awaiting requested review from abalkin
@asvetlov asvetlov Awaiting requested review from asvetlov
@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag
@brettcannon brettcannon Awaiting requested review from brettcannon
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently
@ericvsmith ericvsmith Awaiting requested review from ericvsmith
@ethanfurman ethanfurman Awaiting requested review from ethanfurman
@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti
@gpshead gpshead Awaiting requested review from gpshead
@gvanrossum gvanrossum Awaiting requested review from gvanrossum
@ilevkivskyi ilevkivskyi Awaiting requested review from ilevkivskyi
@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou
@methane methane Awaiting requested review from methane
@ncoghlan ncoghlan Awaiting requested review from ncoghlan
@pablogsal pablogsal Awaiting requested review from pablogsal
@pganssle pganssle Awaiting requested review from pganssle
@rhettinger rhettinger Awaiting requested review from rhettinger
@terryjreedy terryjreedy Awaiting requested review from terryjreedy
@tiran tiran Awaiting requested review from tiran
@vsajip vsajip Awaiting requested review from vsajip
@warsaw warsaw Awaiting requested review from warsaw
1 more reviewer
@koubaa koubaa koubaa left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@encukou @koubaa @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.