GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-34533: Remove all static state from _csv module by eduardo-elizondo · Pull Request #16078 · python/cpython

Conversation

@eduardo-elizondo

@eduardo-elizondo eduardo-elizondo commented Sep 13, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Add all the changes needed to make _csv compatible with PEP384 as well as removing all static state from it

https://bugs.python.org/issue34533

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@eduardo-elizondo
Make _csv compatible with PEP384
60dd2d7
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Sep 13, 2019
@bedevere-bot bedevere-bot added the awaiting review label Sep 13, 2019
@eduardo-elizondo

eduardo-elizondo commented Sep 13, 2019

Copy link
Copy Markdown
Contributor Author

Also, #8977 was trying to address this first but I couldn't manage to get a branch back from that so I just created a new PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou

encukou commented Sep 13, 2019

Copy link
Copy Markdown
Member

The PoC/WIP implementation of PEP 573 should do this plus also remove reliance PyState_FindModule.
I'll concentrate on that PEP rather than on reviewing this.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ericsnowcurrently
ericsnowcurrently self-requested a review September 13, 2019 11:10
@eduardo-elizondo

eduardo-elizondo commented Sep 13, 2019

Copy link
Copy Markdown
Contributor Author

Yup! PEP573 should be the long term solution for getting the module state in C Extensions. We can always go back and update this module once the PEP is finalized. On that note, I have a couple of comments/questions that I've been meaning to post in capi-sig about PEP573. I should prioritize that as well :-)

For now though, this should be ready to be merged as is (pending any in-line comments reviewers might have).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@eduardo-elizondo
Fixes
caf5ecf
@eduardo-elizondo eduardo-elizondo changed the title bpo-34533: Make _csv compatible with PEP384 bpo-34533: Remove all static state from _csv module Sep 23, 2019
@eduardo-elizondo
Update news
1d78d00
@ericsnowcurrently

ericsnowcurrently commented Dec 21, 2019

Copy link
Copy Markdown
Member

Sorry, for the delay, @eduardo-elizondo. I plan on taking a look next Friday.
eduardo-elizondo reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
encukou added a commit to encukou/cpython that referenced this pull request May 19, 2020
@encukou @eduardo-elizondo
Use Eduardo's implementation for csv.dialect __reduce__
d1d1aa2 
See: python#16078
This is slightly nicer.

Co-authored-by: Eddie Elizondo <[email protected]>
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jun 4, 2020
@encukou @eduardo-elizondo @shihai1991
Use Eduardo's implementation for csv.dialect __reduce__
e2b5649 
See: python#16078
This is slightly nicer.

Co-authored-by: Eddie Elizondo <[email protected]>
encukou added a commit to encukou/cpython that referenced this pull request Oct 20, 2020
@encukou Marcel Plch
@eduardo-elizondo @shihai1991
Remove static state from the _csv module
7b33be1 
Uses code from: python#16078

Co-authored-by: Marcel Plch <[email protected]>
Co-authored-by: Eddie Elizondo <[email protected]>
Co-authored-by: Hai Shi <[email protected]>
@encukou

encukou commented Oct 20, 2020

Copy link
Copy Markdown
Member

Here is my attempt: #22838
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
encukou added a commit to encukou/cpython that referenced this pull request Nov 10, 2020
@encukou Marcel Plch
@eduardo-elizondo @shihai1991
Remove static state from the _csv module
a2a0e6f 
Uses code from: python#16078

Co-authored-by: Marcel Plch <[email protected]>
Co-authored-by: Eddie Elizondo <[email protected]>
Co-authored-by: Hai Shi <[email protected]>
@encukou encukou mentioned this pull request Nov 10, 2020
bpo-14935: Remove static state from the _csv module #23224
Merged
encukou added a commit that referenced this pull request Dec 15, 2020
@encukou Marcel Plch
@eduardo-elizondo @shihai1991
bpo-14935: Remove static state from the _csv module (GH-23224)
6a02b38 
Uses code from: #16078

Co-authored-by: Marcel Plch <[email protected]>
Co-authored-by: Eddie Elizondo <[email protected]>
Co-authored-by: Hai Shi <[email protected]>
@encukou

encukou commented Dec 15, 2020

Copy link
Copy Markdown
Member

#23224, which includes this code, is now merged. Thank you for working on this!
eduardo-elizondo reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou encukou closed this Dec 15, 2020
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@encukou Marcel Plch
@eduardo-elizondo @shihai1991 @adorilson
bpo-14935: Remove static state from the _csv module (pythonGH-23224)
94dc70f 
Uses code from: python#16078

Co-authored-by: Marcel Plch <[email protected]>
Co-authored-by: Eddie Elizondo <[email protected]>
Co-authored-by: Hai Shi <[email protected]>
@erlend-aasland erlend-aasland mentioned this pull request May 7, 2023
gh-104265 Disallow instantiation of _csv.Reader and _csv.Writer #104266
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@eduardo-elizondo @encukou @ericsnowcurrently @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.