GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-36876: Fix the C analyzer tool. by ericsnowcurrently · Pull Request #22841 · python/cpython

Conversation

@ericsnowcurrently

@ericsnowcurrently ericsnowcurrently commented Oct 21, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

The original tool wasn't working right and it was simpler to create a new one, partially re-using some of the old code. At this point the tool runs properly on the master. (Try: ./python Tools/c-analyzer/c-analyzer.py analyze.) It take ~35 seconds on my machine to analyze the full CPython code base.

Note that we'll need to iron out some OS-specific stuff (e.g. preprocessor). We're okay though since this tool isn't used yet in our workflow. We will also need to verify the analysis results in detail before activating the check in CI, though I'm pretty sure it's close.

https://bugs.python.org/issue36876

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
ericsnowcurrently added 2 commits October 20, 2020 17:39
@ericsnowcurrently
Drop the old tool.
38490ad
@ericsnowcurrently
Move the new analyzer into place.
04e2cda
@ericsnowcurrently ericsnowcurrently added the skip news label Oct 21, 2020
@ericsnowcurrently
ericsnowcurrently requested a review from vsajip as a code owner October 21, 2020 00:18
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Oct 21, 2020
@bedevere-bot bedevere-bot added the awaiting core review label Oct 21, 2020
@pablogsal

pablogsal commented Oct 21, 2020

Copy link
Copy Markdown
Member

I would recommend checking with the buildbot label before merging as some of the refleaks were reported previously with the old analyzer (although most were false positives).
ericsnowcurrently reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ericsnowcurrently added 2 commits October 22, 2020 16:57
@ericsnowcurrently
Pull in some updates.
a72e916
@ericsnowcurrently
Fix the "full" and "summary" check formats.
6333a55
@ericsnowcurrently

ericsnowcurrently commented Oct 23, 2020

Copy link
Copy Markdown
Member Author

I would recommend checking with the buildbot label before merging as some of the refleaks were reported previously with the old analyzer (although most were false positives).

FWIW, this PR removes all the tool's tests, except for the one we care about (and that one is currently disabled). So refleaks shouldn't be a problem. 😄
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ericsnowcurrently
ericsnowcurrently merged commit 345cd37 into python:master Oct 23, 2020
@bedevere-bot bedevere-bot removed the awaiting core review label Oct 23, 2020
@ericsnowcurrently
ericsnowcurrently deleted the globalss-c-analyzer-total-rewrite branch October 23, 2020 00:42
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@ericsnowcurrently @adorilson
bpo-36876: Fix the C analyzer tool. (pythonGH-22841)
45b7837 
The original tool wasn't working right and it was simpler to create a new one, partially re-using some of the old code. At this point the tool runs properly on the master. (Try: ./python Tools/c-analyzer/c-analyzer.py analyze.)  It take ~40 seconds on my machine to analyze the full CPython code base.

Note that we'll need to iron out some OS-specific stuff (e.g. preprocessor). We're okay though since this tool isn't used yet in our workflow. We will also need to verify the analysis results in detail before activating the check in CI, though I'm pretty sure it's close.

https://bugs.python.org/issue36876
@ericsnowcurrently ericsnowcurrently mentioned this pull request Apr 10, 2022
[subinterpreters] Global C variables are a problem #81057
Closed
@dmacks dmacks mentioned this pull request Feb 18, 2023
Syntax error in _delim.py #102033
Closed
@aisk aisk mentioned this pull request Mar 3, 2024
The README of c-analyzer needs update #116265
Closed
dhejyuyr added a commit to dhejyuyr/cpython that referenced this pull request Mar 24, 2026
@dhejyuyr
fix typo in Function::_unformat_data()
f5a7faa 
Unused datastr variable looks like a typo. Replace sig with datastr.

Fixes: 345cd37 (bpo-36876: Fix the C analyzer tool. (pythonGH-22841))
Signed-off-by: Elizaveta Tereshkina <[email protected]>
@dhejyuyr dhejyuyr mentioned this pull request Mar 24, 2026
Fix C-analyzer Function::_unformat_data() #146372
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vsajip vsajip Awaiting requested review from vsajip

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@ericsnowcurrently @pablogsal @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.