GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-42243: Use PyModule_Add*() in _sre iso. direct module dict manipulation by erlend-aasland · Pull Request #23101 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Nov 2, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

https://bugs.python.org/issue42243

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Erlend E. Aasland
Use PyModule_Add*() in _sre iso. direct module dict manipulation
d0d47d4
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Nov 2, 2020
@bedevere-bot bedevere-bot added the awaiting review label Nov 2, 2020
serhiy-storchaka
serhiy-storchaka reviewed Nov 2, 2020
View reviewed changes
Comment thread Modules/_sre.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/_sre.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka

serhiy-storchaka commented Nov 2, 2020

Copy link
Copy Markdown
Member

Just for the case, add tests that MAXREPEAT and MAXGROUPS > 0.
erlend-aasland reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland
erlend-aasland marked this pull request as draft November 2, 2020 09:20
Erlend E. Aasland
Address review comment: SRE_MAXREPEAT and SRE_MAXGROUPS are unsigned
ab13ae6
@erlend-aasland
erlend-aasland marked this pull request as ready for review November 2, 2020 10:30
@erlend-aasland

erlend-aasland commented Nov 2, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

Just for the case, add tests that MAXREPEAT and MAXGROUPS > 0.

Would a simple assert() be sufficient, or did you mean adding a unit test?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka

serhiy-storchaka commented Nov 3, 2020

Copy link
Copy Markdown
Member

Would a simple assert() be sufficient, or did you mean adding a unit test?

I meant adding a test in Lib/test/test_re.py. If somebody will break this code in future it will get clearer test failure.
erlend-aasland reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Erlend E. Aasland
Test that MAXREPEAT and MAXGROUPS are unsigned
8561628
@erlend-aasland

erlend-aasland commented Nov 3, 2020

Copy link
Copy Markdown
Contributor Author

Would a simple assert() be sufficient, or did you mean adding a unit test?

I meant adding a test in Lib/test/test_re.py. If somebody will break this code in future it will get clearer test failure.

Got it. Signedness test added in 8561628.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland
erlend-aasland requested a review from serhiy-storchaka November 12, 2020 00:02
@erlend-aasland

erlend-aasland commented Nov 17, 2020

Copy link
Copy Markdown
Contributor Author

@serhiy-storchaka are you ok with this PR as it stands?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland erlend-aasland mentioned this pull request Nov 19, 2020
bpo-1635741: Convert _sre types to heap types and establish module state (PEP 384) #23393
Merged
erlend-aasland pushed a commit to erlend-aasland/cpython that referenced this pull request Nov 19, 2020
Erlend E. Aasland
Merge pythonGH-23101
12bf771
@erlend-aasland

erlend-aasland commented Nov 20, 2020

Copy link
Copy Markdown
Contributor Author

Closing, as this was incorporated in #23393
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland erlend-aasland closed this Nov 20, 2020
@erlend-aasland
erlend-aasland deleted the bpo-42243/sre branch December 26, 2020 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka Awaiting requested review from serhiy-storchaka

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@erlend-aasland @serhiy-storchaka @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.