GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-40077: Convert arraymodule to use heap types and establish module state by erlend-aasland · Pull Request #23124 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Nov 3, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Heap types are added to a global state in preparation for module state support.

@corona10 and/or @vstinner, would you mind reviewing this?

https://bugs.python.org/issue40077

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Nov 3, 2020
@bedevere-bot bedevere-bot added the awaiting review label Nov 3, 2020
@erlend-aasland
erlend-aasland marked this pull request as draft November 3, 2020 13:33
@erlend-aasland
erlend-aasland force-pushed the bpo-40077/array branch from 71b9240 to 0de2cfe Compare November 3, 2020 13:38
@erlend-aasland
erlend-aasland marked this pull request as ready for review November 3, 2020 14:08
@erlend-aasland

erlend-aasland commented Nov 3, 2020

Copy link
Copy Markdown
Contributor Author

Ready for review, @corona10 / @vstinner!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner
vstinner reviewed Nov 3, 2020
View reviewed changes
Comment thread Modules/arraymodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Erlend E. Aasland added 9 commits November 3, 2020 23:09
Erlend E. Aasland
Convert array type to heap type
75e7622
Erlend E. Aasland
Convert array iter type to heap type
7b8e273
Erlend E. Aasland
Establish global state and add types to it
3f78766
Erlend E. Aasland
Remove unused check macro
23a582a
Erlend E. Aasland
Use local state variables iso. calling get_array_state() all the time
1869a3a
Erlend E. Aasland
Normalize array type names
88d1928
Erlend E. Aasland
Update clinic
d0ed2f7
Erlend E. Aasland
Add NEWS
a5798e2
Erlend E. Aasland
Use PyModule_AddType()
c3dfade
@erlend-aasland
erlend-aasland force-pushed the bpo-40077/array branch from 807fcb5 to 5586ddf Compare November 3, 2020 22:28
Erlend E. Aasland
Migrate from global to module state
aa3bd22
@erlend-aasland
erlend-aasland force-pushed the bpo-40077/array branch from edf3700 to aa3bd22 Compare November 3, 2020 22:32
Erlend E. Aasland
Fix NEWS
656c5d0
@erlend-aasland erlend-aasland changed the title bpo-40077: Convert arraymodule to use heap types and establish a global state bpo-40077: Convert arraymodule to use heap types and establish module state Nov 3, 2020
vstinner
vstinner reviewed Nov 4, 2020
View reviewed changes
Comment thread Modules/arraymodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner mentioned this pull request Nov 4, 2020
bpo-42100: Add _PyType_GetModuleByDef #22835
Merged
Erlend E. Aasland
Address review comment: adjust naming to reflect time complexity
72434ad
@erlend-aasland

erlend-aasland commented Nov 4, 2020

Copy link
Copy Markdown
Contributor Author

PTAL, @vstinner. I was thinking about including migrating to PyModule_AddObjectRef as well, but I guess we can do that in a separate PR.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions

github-actions Bot commented Dec 16, 2020

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 5 days
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Dec 16, 2020
Erlend Egeberg Aasland
Merge branch 'master' into bpo-40077/array
b86185d
@erlend-aasland

erlend-aasland commented Dec 18, 2020

Copy link
Copy Markdown
Contributor Author

@vstinner Would you mind taking another look at this?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot removed the stale Stale PR or inactive for long period of time. label Dec 19, 2020
encukou
encukou approved these changes Dec 29, 2020
View reviewed changes

@encukou encukou left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do have one nitpick, otherwise the change looks good! Thank you!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland reacted with hooray emoji
All reactions
  • 🎉 1 reaction
Comment thread Modules/arraymodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Dec 29, 2020
Erlend E. Aasland
Address review: Wrap state exclusively used in asserts in #ifndef NDEBUG
f864969
@erlend-aasland

erlend-aasland commented Dec 31, 2020

Copy link
Copy Markdown
Contributor Author

PTAL, @encukou
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou
encukou merged commit 75bf107 into python:master Jan 2, 2021
@bedevere-bot bedevere-bot removed the awaiting merge label Jan 2, 2021
@erlend-aasland
erlend-aasland deleted the bpo-40077/array branch January 2, 2021 16:56
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
Erlend Egeberg Aasland @adorilson
bpo-40077: Convert arraymodule to use heap types and establish module…
d595e0e 
… state (pythonGH-23124)
@corona10 corona10 mentioned this pull request Jun 27, 2022
Convert static types to heap types: use PyType_FromSpec() #84258
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner left review comments
@encukou encukou encukou approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@erlend-aasland @vstinner @encukou @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.