GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — bpo-42207: Disable peg generator tests when building with PGO by serge-sans-paille · Pull Request #23141 · python/cpython

bpo-42207: Disable peg generator tests when building with PGO #23141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

pablogsal merged 1 commit into python:master from serge-sans-paille:master

Nov 4, 2020

Uh oh!

There was an error while loading. Please reload this page.

Merged

bpo-42207: Disable peg generator tests when building with PGO #23141

Changes from all commits

Commits

Show all changes

1 commit

Select commit

5eb1506

Disable peg generator tests when building with PGO

serge-sans-paille Nov 3, 2020

File filter

Filter by extension .py (1) All 1 file type selected

Viewed files

Clear filters

Conversations

Failed to load comments.

Uh oh!

There was an error while loading. Please reload this page.

Jump to

Jump to file

Failed to load files.

Uh oh!

There was an error while loading. Please reload this page.

Diff view

Unified

Split

Hide whitespace

Diff view

Unified

Split

Hide whitespace

There are no files selected for viewing

6 changes: 6 additions & 0 deletions 6 Lib/test/test_peg_generator/test_c_parser.py

Show comments

View file

Open in desktop

Original file line number	Diff line number	Diff line change
		@@ -1,3 +1,4 @@
		import sysconfig
		import textwrap
		import unittest
		from distutils.tests.support import TempdirManager
Expand All		@@ -8,6 +9,11 @@
		from test.support import os_helper
		from test.support.script_helper import assert_python_ok

		_py_cflags_nodist = sysconfig.get_config_var('PY_CFLAGS_NODIST')
		_pgo_flag = sysconfig.get_config_var('PGO_PROF_USE_FLAG')
		if _pgo_flag and _py_cflags_nodist and _pgo_flag in _py_cflags_nodist:
		raise unittest.SkipTest("peg_generator test disabled under PGO build")

		test_tools.skip_if_missing("peg_generator")
		with test_tools.imports_under_tool("peg_generator"):
		from pegen.grammar_parser import GeneratedParser as GrammarParser
Expand Down

Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.