GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-41282: (PEP 632) Deprecate distutils.sysconfig (partial implementation of the PEP) by frenzymadness · Pull Request #23142 · python/cpython

Conversation

@frenzymadness

@frenzymadness frenzymadness commented Nov 4, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This change:

  • merges distutils.sysconfig into sysconfig while keeping the original functionality and
  • marks distutils.sysconfig as deprecated

Commits basically describe my progress step by step. Some discussions already happened in my private PR.

PEP 632 is still a draft so I'm opening this PR the same. PEP proposal and discussion.

https://bugs.python.org/issue41282

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
yan12125 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@frenzymadness
frenzymadness requested review from lysnikolaou and pablogsal as code owners November 4, 2020 11:28
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Nov 4, 2020
@bedevere-bot bedevere-bot added the awaiting review label Nov 4, 2020
@frenzymadness frenzymadness mentioned this pull request Nov 4, 2020
Sysconfig merge frenzymadness/cpython#2
Closed
@frenzymadness
frenzymadness marked this pull request as draft November 4, 2020 11:31
@merwok merwok added the DO-NOT-MERGE label Nov 4, 2020
merwok
merwok reviewed Nov 4, 2020
View reviewed changes
Comment thread Lib/sysconfig.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
merwok
merwok reviewed Nov 4, 2020
View reviewed changes
Comment thread Lib/sysconfig.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@zooba zooba self-assigned this Nov 4, 2020
@frenzymadness
frenzymadness force-pushed the distutils_sysconfig branch from 70fe4be to 7d6d0bb Compare November 13, 2020 11:47
@github-actions

github-actions Bot commented Dec 16, 2020

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 5 days
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Dec 16, 2020
@merwok merwok removed the stale Stale PR or inactive for long period of time. label Dec 16, 2020
@frenzymadness

frenzymadness commented Dec 16, 2020

Copy link
Copy Markdown
Contributor Author

This PR is waiting for a final decision about the PEP.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions

github-actions Bot commented Jan 16, 2021

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Jan 16, 2021
@merwok merwok removed awaiting review stale Stale PR or inactive for long period of time. labels Jan 16, 2021
@pradyunsg

pradyunsg commented Jan 23, 2021

Copy link
Copy Markdown
Member

The PEP is accepted now.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
merwok
merwok reviewed Jan 23, 2021
View reviewed changes
Comment thread Doc/distutils/apiref.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@frenzymadness
frenzymadness force-pushed the distutils_sysconfig branch from 7d6d0bb to 51c232c Compare February 9, 2021 12:06
@frenzymadness frenzymadness changed the title PEP 632: Deprecate distutils.sysconfig (partial implementation of the PEP) bpo-41282: (PEP 632) Deprecate distutils.sysconfig (partial implementation of the PEP) Feb 9, 2021
@frenzymadness

frenzymadness commented Feb 9, 2021

Copy link
Copy Markdown
Contributor Author

The pep is accepted so this PR is no longer a draft. Also, a note about the deprecation already exists here so I think it's enough to mention it once.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@frenzymadness
frenzymadness marked this pull request as ready for review February 9, 2021 12:38
@encukou

encukou commented Feb 12, 2021

Copy link
Copy Markdown
Member

Can you add a NEWS entry?
(The blurb tool is packaged in Fedora, FWIW.)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@frenzymadness

frenzymadness commented Feb 15, 2021

Copy link
Copy Markdown
Contributor Author

News entry added.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@zooba

zooba commented Feb 15, 2021

Copy link
Copy Markdown
Member

I have no other comments, so unless someone else spots something I'll get this merged before the next alpha release. Thanks, @frenzymadness!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@frenzymadness

frenzymadness commented Feb 28, 2021

Copy link
Copy Markdown
Contributor Author

I have no other comments, so unless someone else spots something I'll get this merged before the next alpha release. Thanks, @frenzymadness!

Thank you! AFAIK the next alpha should be released tomorrow. Will we include this in it?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@frenzymadness
Mark distutils.sysconfig as deprecated
9de38bb
@frenzymadness
Rename distutils_compat to keep_unresolved and reverse the logic
318428d
@frenzymadness
frenzymadness force-pushed the distutils_sysconfig branch from 8d73015 to cf2bb35 Compare April 16, 2021 07:01
frenzymadness added 10 commits April 16, 2021 09:22
@frenzymadness
Merge all import from sysconfig to one statement
6136978
@frenzymadness
Allow import of sysconfig when re module is not available
e635dbd
@frenzymadness
Add a TODO comment about PEP 632
d8a8cf0
@frenzymadness
Mark distutils.sysconfig as deprecated in docs
e317db5
@frenzymadness
Copy docs for get_python_inc and get_python_lib from distutils.syscon…
17206f0 
…fig to sysconfig
@frenzymadness
Move customize_compiler back to distutils.sysconfig as it'll be remov…
04ef7af 
…edtogether with the module.
@frenzymadness
Fix import of not-yet-initialized _CONFIG_VARS
6015255
@frenzymadness
Switch global vars from regex objects to raw strings and import re on…
abc310b 
…ly when needed
@frenzymadness
Move get_python_lib and get_python_inc back to distutils.sysconfig
17aa9c4 
and deprecated them.
@frenzymadness
News entry
be181b6
@frenzymadness
frenzymadness force-pushed the distutils_sysconfig branch from cf2bb35 to be181b6 Compare April 16, 2021 07:27
@frenzymadness

frenzymadness commented Apr 16, 2021

Copy link
Copy Markdown
Contributor Author

I've rebased the commits and fixed a conflict. The failing test is not related to this change.

Could you please merge this?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@frenzymadness
Restore build_flags accidentally removed during a rebase
e253a3d
@frenzymadness

frenzymadness commented Apr 16, 2021

Copy link
Copy Markdown
Contributor Author

@encukou see the last commit and PTAL.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pradyunsg

pradyunsg commented Apr 16, 2021

Copy link
Copy Markdown
Member

And... Could someone also relabel this, to remove the "DO-NOT-MERGE" label here? :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou encukou removed the DO-NOT-MERGE label Apr 16, 2021
merwok
merwok reviewed Apr 16, 2021
View reviewed changes
Comment thread Doc/distutils/apiref.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@frenzymadness @merwok
Update Doc/distutils/apiref.rst
cd8e387 
Co-authored-by: Éric Araujo <[email protected]>
@frenzymadness

frenzymadness commented Apr 22, 2021

Copy link
Copy Markdown
Contributor Author

@zooba could you please take a look at this PR? The time of the first beta release is approaching.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou

encukou commented Apr 23, 2021

Copy link
Copy Markdown
Member

The patch looks good to me, it was seen by many people and I see no objections. I'll merge and watch the buildbots.
pradyunsg and frenzymadness reacted with heart emoji
All reactions
  • ❤️ 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou
encukou merged commit 90d02e5 into python:master Apr 23, 2021
@frenzymadness
frenzymadness deleted the distutils_sysconfig branch April 26, 2021 08:00
@hroncok

hroncok commented Jun 8, 2021

Copy link
Copy Markdown
Contributor

I think there is a regression in distutils.sysconfig.parse_makefile() caused by this change.

https://bugs.python.org/issue44351
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@frenzymadness frenzymadness mentioned this pull request Jun 10, 2021
bpo-44351: Restore back parse_makefile in distutils.sysconfig #26637
Merged
This was referenced Dec 21, 2021
bpo-41282: Load install schemes from sysconfig (port from CPython) pypa/distutils#84
Closed
[BUG] No module named '_sysconfigdata_d_linux_x86_64-linux-gnu' pypa/setuptools#2946
Closed
@jaraco jaraco mentioned this pull request May 9, 2022
Deprecate and remove distutils #85454
Closed
@jkloth jkloth mentioned this pull request May 18, 2022
gh-92897: Ensure venv --copies respects source build property of the creating interpreter (GH-92899) #92899
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@merwok merwok merwok left review comments
@pradyunsg pradyunsg pradyunsg left review comments
@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou
@pablogsal pablogsal Awaiting requested review from pablogsal

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@zooba zooba

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@frenzymadness @pradyunsg @encukou @zooba @hroncok @merwok @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.