GeezerVison is showing github.com — bpo-44351: Restore back parse_makefile in distutils.sysconfig by frenzymadness · Pull Request #26637 · python/cpython
Conversation
frenzymadness
commented
Jun 10, 2021
•
edited by bedevere-bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
The function uses distutils.text_file.TextFile and therefore
behaves differently than _parse_makefile in sysconfig.
This is a regression caused by a try to merge distutils.sysconfig and sysconfig in #23142
https://bugs.python.org/issue44351
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
The function uses distutils.text_file.TextFile and therefore
behaves differently than _parse_makefile in sysconfig.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code is different than Python 3.9 code wrt. compiled re patterns / strings. The differences are reasonable. Other than that, it is a straight revert / restore.
I'd add a regression test, however this is distutils, so not a hard requirement.
Thank you.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Thanks @frenzymadness for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 11, 2021
…GH-26637)
The function uses distutils.text_file.TextFile and therefore
behaves differently than _parse_makefile in sysconfig.
(cherry picked from commit fc98266)
Co-authored-by: Lumír 'Frenzy' Balhar <[email protected]>
encukou
pushed a commit
that referenced
this pull request
Jun 15, 2021
…) (GH-26673)
The function uses distutils.text_file.TextFile and therefore
behaves differently than _parse_makefile in sysconfig.
(cherry picked from commit fc98266)
Co-authored-by: Lumír 'Frenzy' Balhar <[email protected]>
Reviewers
1 more reviewer
hroncok
hroncok approved these changes
Reviewers whose approvals may not affect merge requirements
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.