GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-41712 Vulnerable Regex Changed by Pixmew · Pull Request #23191 · python/cpython

Conversation

@Pixmew

@Pixmew Pixmew commented Nov 7, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

The regex is changed because /w contains extra special characters which maybe invalid hence is converted to [A-Za-z_].

https://bugs.python.org/issue41712

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Pixmew and others added 10 commits November 5, 2020 20:41
@Pixmew
Unnessery regex conditions are removed
eac3276 
bpo-41712: Removal of Unnessery regex conditions  
Using suggestion 
For example, you can modify the sub-pattern \w+\d+ to ([A-Za-z_]*\d)+
which should Fix the issue of vulnerable regex.
Test Result : Working as intended

Sorry if this not much this is my first pr to big org.
@Pixmew
Vulnerable regex conditions are removed
f3f4725 
bpo-41712: Removal of Vulnerable regex conditions  
Using suggestion  ""For example, you can modify the sub-pattern \w+\d+ to ([A-Za-z_]*\d)+""  and converted to ([A-za-z_]+\d+)
which should Fix the issue of vulnerable regex.
Test Result : Working as intended

Sorry if this not much this is my first pr to big org.
@blurb-it
📜🤖 Added by blurb_it.
8e502ad
@Pixmew
edited
9a4c1a5
@Pixmew
edited for avoiding docs failure
fddf4f1
@blurb-it
📜🤖 Added by blurb_it.
d4004c6
@Pixmew
linux test failure reason
40b6373
@Pixmew @Fidget-Spinner
Update Misc/NEWS.d/next/Tools-Demos/2020-11-06-09-12-13.bpo-41712.WOE…
52f7af2 
…kdm.rst

Co-authored-by: kj <[email protected]>
@Pixmew @Fidget-Spinner
Update Tools/msi/purge.py
eb1500c 
Co-authored-by: kj <[email protected]>
@Pixmew
Updated news
aab27c2
@Pixmew
Pixmew requested a review from a team as a code owner November 7, 2020 15:20
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Nov 7, 2020
@bedevere-bot bedevere-bot added the awaiting review label Nov 7, 2020
@Pixmew Pixmew mentioned this pull request Nov 7, 2020
bpo-41712: Vulnerable regex changed #23166
Merged
@Pixmew Pixmew closed this Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@Pixmew @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.